Repository navigation
chore: finish the template upgrade, without the verbatim documents (replaces #26, needs the #24 replacement) - #29
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d19d8f5f85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| echo "═══════════════════════════════════════════════════════════════" | ||
| echo " BACTRIAN — Aspect Tests (Cross-Cutting Concerns)" | ||
| echo " {{PROJECT}} — Aspect Tests (Cross-Cutting Concerns)" |
There was a problem hiding this comment.
Keep the aspect report labeled with the repository name
Running bash tests/aspect_tests.sh now prints the literal {{PROJECT}} in its heading. This token is not one of repo-init's substitutions, and the same commit adds this script to .machine_readable/mint-verbatim.txt, so neither this repository nor a chain-minted child will replace it; test reports consequently lose their project identity.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified and real: tests/aspect_tests.sh is carried verbatim, so its banner printed the project token literally. Fixed at the source: rsr-template-repo#390 (merged) makes the banner use the runtime directory name, with a guard test. This repository gets the fixed file with the template catch-up; not edited here to keep the byte-identity this PR keeps. Left unresolved until then.
Generated by Claude Code
| # Verify the real substitution expression reaches Project.toml, including | ||
| # every occurrence of the token in the new explanatory comment. | ||
| mapfile -d '' -t sed_args < "$fixture/sed.args" | ||
| sed "${sed_args[@]}" "$repo/archetypes/julia-library/overlay/Project.toml.in" > "$fixture/Project.toml" |
There was a problem hiding this comment.
Do not run the Julia test against a removed overlay
The documented bash tests/workflows/julia_library_test.sh invocation always fails in this instantiated repository because archetypes/julia-library/overlay/Project.toml.in does not exist (there is no archetypes/ tree). The new test reaches this line and exits with sed: can't read ... before completing its assertions, so it needs to use an available fixture or explicitly skip when the template overlay is absent.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified and real (same finding as #28's thread): the test reads archetypes/julia-library/..., which the mint removes. Fixed at the source in rsr-template-repo#394 (the test skips loudly when the overlay is absent; a guard runs every carried test in a child-shaped tree). This repository gets the guarded file with the template catch-up. Not changed here, to keep the file byte-identical to the template; no CI in this repository invokes it, so nothing is red from it. Left unresolved until #394 merges.
Generated by Claude Code
| // SPDX-License-Identifier: CC-BY-SA-4.0 | ||
| // Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk> | ||
| = TEST-NEEDS: bactrian | ||
| = TEST-NEEDS: rsr-template-repo |
There was a problem hiding this comment.
Preserve Bactrian's identity in the test-needs document
This is the bactrian repository, but the change relabels its test-status document as rsr-template-repo. Moreover, the same commit lists this document in .machine_readable/mint-verbatim.txt, preventing the mint's self-name pass from correcting the stale template identity in descendants; keep the current repository name here rather than restoring the upstream template name.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Verified and real: docs/status/TEST-NEEDS.adoc carries the template's title because it is listed verbatim, so the self-name pass cannot correct it. Fixed at the source: rsr-template-repo#393 (reword the one brace-token line, drop the file from the verbatim list, guard test with 3 controls). When #393 merges, bactrian's title and template counts get a small normal PR; not edited here. Left unresolved until then.
Generated by Claude Code
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit a7de0af)
… the rule order Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit ba3baa5)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit 523eeba)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ (cherry picked from commit 7f7e602)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
d19d8f5 to
21804c6
Compare
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 21804c69e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| ||| Raw FFI call to initialize the library (Zig: returns ?*Handle, null on failure) | ||
| %foreign "C:{{project}}_init,lib{{project}}" | ||
| %foreign "C:bactrian_init,libbactrian" |
There was a problem hiding this comment.
Preserve identifier normalization in chain mints
When a descendant is chain-minted with a normal hyphenated slug such as my-app, the supported self-name pass rewrites this new literal to my-app_init rather than the normalized my_app_init that PROJECT_LOWER produces, while libbactrian is not rewritten at all because bactrian is embedded after lib. Since scripts/chain-mint.sh applies that pass to inherited changes, descendants receive invalid/missing FFI symbols and continue loading the parent's library; these bindings need an identifier-aware chain rewrite rather than the bounded repository-name rewrite.
Useful? React with 👍 / 👎.
…atim TEST-NEEDS.adoc was carried verbatim (mint-verbatim.txt), so its title read "rsr-template-repo" in this repository (Codex review on #29). The template fixed the cause at source in rsr-template-repo#393: the one brace-token line is reworded and the file leaves the verbatim list, so the self-name pass sets the title. This applies the same: the template's file with the title set to bactrian, and the entry removed from mint-verbatim.txt. The template's counts inside the document are template content and are not changed here. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
…atim (#34) TEST-NEEDS.adoc was carried verbatim (mint-verbatim.txt), so its title read "rsr-template-repo" in this repository (Codex review on #29). The template fixed the cause at source in rsr-template-repo#393: the one brace-token line is reworded and the file leaves the verbatim list, so the self-name pass sets the title. This applies the same: the template's file with the title set to bactrian, and the entry removed from mint-verbatim.txt. The template's counts inside the document are template content and are not changed here. Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ Co-authored-by: Claude <noreply@anthropic.com>



Replaces #26. Depends on #28 (
fix/mint-verbatim-documents-v2, the #24 replacement) and must merge after it.julia_library_test.sh. The five commits are the same signed cherry-picks; the repository-map commit was regenerated and is identical.tests/workflows/julia_library_test.sh(202 lines), which comes from the chore: carry the template's prose-token documents verbatim (mint-verbatim sync) #24 replacement. Nothing else moved.The first four files of this PR's diff against main (
.machine_readable/mint-verbatim.txt,CHANGELOG.adoc,docs/status/TEST-NEEDS.adoc,tests/aspect_tests.sh, plusjulia_library_test.sh) are the #24 replacement's and disappear from the diff once it merges. Its own content, one commit each: drop the retired.cursorrulesand.windsurfrules; remove the stalebuild/docs-seed/exemption and refresh the rule order; fill the README repo-init sentence; fill the{{project}}tokens inForeign.idrandTypes.idr; regenerate the repository map.Checked locally:
check-no-placeholders.sh,check-mint-tokens.sh,check-hypatia-ignore.shandcheck-hypatia-rule-order.shexit 0, and all 21 manifest entries exist.check-internal-links.sh(3 dead links, the links slice) andcheck-container-pins.sh(floating base image, the digest-pin slice) fail on the base too and are not caused here. Not proven here: a CI run.https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
Generated by Claude Code