Skip to content

chore: finish the template upgrade, without the verbatim documents (replaces #26, needs the #24 replacement) - #29

Merged
hyperpolymath merged 5 commits into
mainfrom
fix/finish-template-upgrade-without-verbatim-v2
Nov 14, 2026
Merged

hyperpolymath merged 5 commits into
mainfrom
fix/finish-template-upgrade-without-verbatim-v2

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

Replaces #26. Depends on #28 (fix/mint-verbatim-documents-v2, the #24 replacement) and must merge after it.

The first four files of this PR's diff against main (.machine_readable/mint-verbatim.txt, CHANGELOG.adoc, docs/status/TEST-NEEDS.adoc, tests/aspect_tests.sh, plus julia_library_test.sh) are the #24 replacement's and disappear from the diff once it merges. Its own content, one commit each: drop the retired .cursorrules and .windsurfrules; remove the stale build/docs-seed/ exemption and refresh the rule order; fill the README repo-init sentence; fill the {{project}} tokens in Foreign.idr and Types.idr; regenerate the repository map.

Checked locally: check-no-placeholders.sh, check-mint-tokens.sh, check-hypatia-ignore.sh and check-hypatia-rule-order.sh exit 0, and all 21 manifest entries exist. check-internal-links.sh (3 dead links, the links slice) and check-container-pins.sh (floating base image, the digest-pin slice) fail on the base too and are not caused here. Not proven here: a CI run.

https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ


Generated by Claude Code

@coderabbitai

coderabbitai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 57 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 5c5cc38 and 21804c6.

Files selected for processing: 8

  • .cursorrules
  • .hypatia-ignore
  • .machine_readable/policies/hypatia-rule-order.json
  • .windsurfrules
  • README.adoc
  • docs/architecture/REPOSITORY-MAP.adoc
  • src/interface/Abi/Foreign.idr
  • src/interface/Abi/Types.idr

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T17:28:06.409076Z 21804c6 New commits
🔒 Security Review ✅ Completed 2026-11-14T17:26:18.203209Z 21804c6 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d19d8f5f85

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/aspect_tests.sh

echo "═══════════════════════════════════════════════════════════════"
echo " BACTRIAN — Aspect Tests (Cross-Cutting Concerns)"
echo " {{PROJECT}} — Aspect Tests (Cross-Cutting Concerns)"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the aspect report labeled with the repository name

Running bash tests/aspect_tests.sh now prints the literal {{PROJECT}} in its heading. This token is not one of repo-init's substitutions, and the same commit adds this script to .machine_readable/mint-verbatim.txt, so neither this repository nor a chain-minted child will replace it; test reports consequently lose their project identity.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and real: tests/aspect_tests.sh is carried verbatim, so its banner printed the project token literally. Fixed at the source: rsr-template-repo#390 (merged) makes the banner use the runtime directory name, with a guard test. This repository gets the fixed file with the template catch-up; not edited here to keep the byte-identity this PR keeps. Left unresolved until then.


Generated by Claude Code

# Verify the real substitution expression reaches Project.toml, including
# every occurrence of the token in the new explanatory comment.
mapfile -d '' -t sed_args < "$fixture/sed.args"
sed "${sed_args[@]}" "$repo/archetypes/julia-library/overlay/Project.toml.in" > "$fixture/Project.toml"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not run the Julia test against a removed overlay

The documented bash tests/workflows/julia_library_test.sh invocation always fails in this instantiated repository because archetypes/julia-library/overlay/Project.toml.in does not exist (there is no archetypes/ tree). The new test reaches this line and exits with sed: can't read ... before completing its assertions, so it needs to use an available fixture or explicitly skip when the template overlay is absent.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and real (same finding as #28's thread): the test reads archetypes/julia-library/..., which the mint removes. Fixed at the source in rsr-template-repo#394 (the test skips loudly when the overlay is absent; a guard runs every carried test in a child-shaped tree). This repository gets the guarded file with the template catch-up. Not changed here, to keep the file byte-identical to the template; no CI in this repository invokes it, so nothing is red from it. Left unresolved until #394 merges.


Generated by Claude Code

// SPDX-License-Identifier: CC-BY-SA-4.0
// Copyright (c) Jonathan D.A. Jewell <j.d.a.jewell@open.ac.uk>
= TEST-NEEDS: bactrian
= TEST-NEEDS: rsr-template-repo

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve Bactrian's identity in the test-needs document

This is the bactrian repository, but the change relabels its test-status document as rsr-template-repo. Moreover, the same commit lists this document in .machine_readable/mint-verbatim.txt, preventing the mint's self-name pass from correcting the stale template identity in descendants; keep the current repository name here rather than restoring the upstream template name.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and real: docs/status/TEST-NEEDS.adoc carries the template's title because it is listed verbatim, so the self-name pass cannot correct it. Fixed at the source: rsr-template-repo#393 (reword the one brace-token line, drop the file from the verbatim list, guard test with 3 controls). When #393 merges, bactrian's title and template counts get a small normal PR; not edited here. Left unresolved until then.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit a7de0af)
… the rule order

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit ba3baa5)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit 523eeba)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
(cherry picked from commit 7f7e602)
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
@hyperpolymath
hyperpolymath force-pushed the fix/finish-template-upgrade-without-verbatim-v2 branch from d19d8f5 to 21804c6 Compare November 14, 2026 17:23
@hyperpolymath
hyperpolymath merged commit 0a1c837 into main Nov 14, 2026
@hyperpolymath
hyperpolymath deleted the fix/finish-template-upgrade-without-verbatim-v2 branch November 14, 2026 17:23
@sonarqubecloud

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21804c69e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".


||| Raw FFI call to initialize the library (Zig: returns ?*Handle, null on failure)
%foreign "C:{{project}}_init,lib{{project}}"
%foreign "C:bactrian_init,libbactrian"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve identifier normalization in chain mints

When a descendant is chain-minted with a normal hyphenated slug such as my-app, the supported self-name pass rewrites this new literal to my-app_init rather than the normalized my_app_init that PROJECT_LOWER produces, while libbactrian is not rewritten at all because bactrian is embedded after lib. Since scripts/chain-mint.sh applies that pass to inherited changes, descendants receive invalid/missing FFI symbols and continue loading the parent's library; these bindings need an identifier-aware chain rewrite rather than the bounded repository-name rewrite.

Useful? React with 👍 / 👎.

hyperpolymath pushed a commit that referenced this pull request Nov 14, 2026
…atim

TEST-NEEDS.adoc was carried verbatim (mint-verbatim.txt), so its title read
"rsr-template-repo" in this repository (Codex review on #29). The template
fixed the cause at source in rsr-template-repo#393: the one brace-token line
is reworded and the file leaves the verbatim list, so the self-name pass sets
the title. This applies the same: the template's file with the title set to
bactrian, and the entry removed from mint-verbatim.txt.

The template's counts inside the document are template content and are not
changed here.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ
hyperpolymath added a commit that referenced this pull request Nov 14, 2026
…atim (#34)

TEST-NEEDS.adoc was carried verbatim (mint-verbatim.txt), so its title read
"rsr-template-repo" in this repository (Codex review on #29). The template
fixed the cause at source in rsr-template-repo#393: the one brace-token line
is reworded and the file leaves the verbatim list, so the self-name pass sets
the title. This applies the same: the template's file with the title set to
bactrian, and the entry removed from mint-verbatim.txt.

The template's counts inside the document are template content and are not
changed here.


Claude-Session: https://claude.ai/code/session_0136P7Zm6f3TYUpUuzGd5KAQ

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants