Repository navigation
Reconcile release journeys and retain native renewal failure state - #524
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
@codex review Review exact head |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Manual iOS validation rejected two existing subscription-utilization UI tests missing from the release manifest, stopping before XCTest. Include both in the supplemental phase, preserve the existing51 journeys and require53 per family plus the same three preparation/reset invocations. Update the strict manifest/source-discovery contract and developer documentation.
Also retain the last native auto-renew-off predicate observation if its existing25-second wait fails. The failure-only capture preserves short-circuit evaluation, caps fixed-product status output at3 rows with explicit counts, and retains the primary failure if diagnostics fail. No production source, workflow, automatic workload, timeout, test selector, acceptance assertion or marketing exclusion is weakened.
Refs #523. Extracts the existing manifest correction from PR #521, whose source and separate cost/full-qualification evidence remain unchanged. Reviewed/tested head:
4e4a3c34173eb7762b7431328e86c2af3c659c30.Validation
Limits and retained adverse evidence
Previous validation40318765544 failed the natural-expiration auto-renew-off wait. One isolated and one ordered local control did not reproduce it; the new hosted run passed it. Its cause remains unexplained, and this diagnostic update is not a claimed causal product fix. Raw failures, local controls and source ledgers remain under
/tmp/codexbar-main-ci-20261026/.A temporary supported SDK-error injection verified the final failure capture and original exit65, but its separate reset hit simulator Busy/preflight and internal simctl lookup errors. Shutdown passed; that simulator is quarantined and the whole local control is unqualified. The injection was removed and exact final compiled Swift bytes restored before commit.
This focused run intentionally skipped the full53-journey release UI gate. It does not qualify an App Store release or PR #521's full sharding/cost gates. Current standalone Usage history performance is also unqualified; its historical noisy failure is retained. No Home sync, Store/release action, polling/timer or CI-notification change. The external Chief supplied the workflow-completion wake; the PR watch alone did not establish it.