Repository navigation
Accept the system In progress prefix in ProgressView unit tests - #528
Merged
Merged
Conversation
With app accessibility enabled on the simulator, SwiftUI reads a labelled ProgressView as "In progress, <label>". Hosted iOS test runs sometimes start in that state, which failed the loading and Use Reset progress tests in main CI. Accept exactly the label or its In progress form, and wait for the dashboard body before checking the loading state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main CI run 40502617023 at
a96e436failed in the iOS tests job: 1,182 tests passed and 2 failed. The original red step, "Verify function risk and release phase failure fixtures", now passes because of #524.Both failures read a labelled SwiftUI
ProgressView. They got"In progress, Loading accounts…"and"In progress, Using reset…"where the tests expected the bare labels. The same pair failed the same way on October 22 (run 39799242125, a different image). Three hosted runs on the current image passed without any change to the views or tests.Cause, reproduced on air: SwiftUI adds this prefix while the simulator has app accessibility enabled. With
com.apple.Accessibility ApplicationAccessibilityEnabledset on an iOS 26.2 iPhone Air under Xcode 26.6 17F113, maina96e436fails both tests with the exact CI labels. Both labels are real system output, and the prefixed form is what accessibility clients receive.Changes, tests only, with no product or accessibility text changes:
HostedViewProbe.isProgressLabel(_:_:)accepts exactly"<label>"or"In progress, <label>". A new test shows it rejects nil, empty, partial, reversed and other-label strings.["Open settings", "Refresh usage"]), so the unchanged test failed 1 in 5 locally. That is a separate race from the CI failure.Closes #527.
Validation
On air, with Xcode 26.6 (17F113), an iOS 26.2 iPhone Air (
23C54), the CI runtime:a96e436)e26fbc4)CodexBarIOSTestsOS=latestbuild-for-testingwarningsThe simulator's accessibility default was restored after the runs.
Automatic CI: no workflow changes, and
CodexBarIOSTestsis not run by automatic PR CI. That CI runs pinned SwiftLint and the policy tests only, so automatic cost is unchanged.After merge: one manual
ci.ymldispatch on main proves main green. Live provider checks don't apply.🤖 Generated with Claude Code