Fix renameFileWithRetry leaving temporary files after copying

[Bodigrim]

@ffaf1 @TravisCardwell could you please check whether this fixes #12244?

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
  • Is the change significant? If so, remember to add significance: significant in the changelog file.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

[TravisCardwell]

I tried it, and no .tmp files are left in /tmp. 🎉

Taking a look at the change, I noticed that retriesLeft is no longer decremented. Investigating the full function, it indeed does not need to be decremented on the changed line, but it should be decremented in the exception handler for the copyFile call here. As is, retryCopy may loop indefinitely.

[Bodigrim]

@TravisCardwell good catch, should be fixed now.

[ulysses4ever]

it might be good to check again that this does indeed solve the issue

[TravisCardwell]

I tried it again, and no .tmp files are left in /tmp. 🎉

[ffaf1]

Thanks!
I confirm it fixes the issue on my machine.

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-08-22 02:45 UTC · Rule: default · triggered by rule Put pull requests in the rebase+merge queue
• ✅ Checks passed · on draft merge queue: checking master (36357f2), #12191 and #12246 together #12254
• ✅ Merged — 2026-08-22 04:45 UTC · at 5078e7d6a1b63e69a0ac03742f26f53f2eb8a679 · merge

This pull request spent 1 hour 59 minutes 45 seconds in the queue, including 1 hour 48 minutes 30 seconds running CI.

Required conditions to merge

• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • Fix renameFileWithRetry leaving temporary files after copying #12246
• github-review-approved [🛡 GitHub branch protection]
  • Fix renameFileWithRetry leaving temporary files after copying #12246
• any of [🛡 GitHub branch protection]:
  • check-success = Doctest Cabal
  • check-neutral = Doctest Cabal
  • check-skipped = Doctest Cabal
• any of [🛡 GitHub branch protection]:
  • check-success = Meta checks
  • check-neutral = Meta checks
  • check-skipped = Meta checks
• any of [🛡 GitHub branch protection]:
  • check-success = docs/readthedocs.org:cabal
  • check-neutral = docs/readthedocs.org:cabal
  • check-skipped = docs/readthedocs.org:cabal
• any of [🛡 GitHub branch protection]:
  • check-success = Validate post job
  • check-neutral = Validate post job
  • check-skipped = Validate post job
• any of [🛡 GitHub branch protection]:
  • check-success = fourmolu
  • check-neutral = fourmolu
  • check-skipped = fourmolu
• any of [🛡 GitHub branch protection]:
  • check-success = hlint
  • check-neutral = hlint
  • check-skipped = hlint
• any of [🛡 GitHub branch protection]:
  • check-success = Bootstrap post job
  • check-neutral = Bootstrap post job
  • check-skipped = Bootstrap post job
• any of [🛡 GitHub branch protection]:
  • check-success = whitespace
  • check-neutral = whitespace
  • check-skipped = whitespace
• any of [🛡 GitHub branch protection]:
  • check-success = Check sdist post job
  • check-neutral = Check sdist post job
  • check-skipped = Check sdist post job
• any of [🛡 GitHub branch protection]:
  • check-success = Changelogs
  • check-neutral = Changelogs
  • check-skipped = Changelogs

[zlonast]

@mergify backport 3.18

[mergify]

backport 3.18

✅ Backports have been created

Details

• #12298 Backport #12246: Fix renameFileWithRetry leaving temporary files after copying has been created for branch 3.18

[ulysses4ever]

no changelog entry :-(

[ffaf1]

no changelog entry :-(

No worries, I spotted/added it manually in #12346