Skip to content

Fix renameFileWithRetry leaving temporary files after copying #12246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 1 commit into from
Aug 22, 2026
+2 −2
Merged

Fix renameFileWithRetry leaving temporary files after copying #12246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cabal-syntax/src/Distribution/Utils/Generic.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ renameFileWithRetry srcPath targetPath =
-- UnsupportedOperation means EXDEV from rename(2) with source and target
-- on different devices. In such case we resort to copying instead of renaming.
| ioeGetErrorType exception == UnsupportedOperation =
copyFile srcPath targetPath `Exception.catch` retryCopy (retriesLeft - 1)
retryCopy retriesLeft exception
| otherwise = do
-- Wait 1ms between retries: maybe device is busy, maybe antivirus locked srcPath.
threadDelay 1000
Expand All @@ -217,7 +217,7 @@ renameFileWithRetry srcPath targetPath =
retryCopy retriesLeft _ = do
-- Wait 1ms between retries: maybe device is busy, maybe antivirus locked srcPath.
threadDelay 1000
copyFile srcPath targetPath `Exception.catch` retryCopy retriesLeft
copyFile srcPath targetPath `Exception.catch` retryCopy (retriesLeft - 1)
-- It's nice to clean up, but not critical, so ignoring any exceptions.
removeFile srcPath `Exception.catch` (\(_ :: IOException) -> pure ())

Expand Down
Loading