Backport #12246: Fix renameFileWithRetry leaving temporary files after copying

[mergify]

@ffaf1 @TravisCardwell could you please check whether this fixes #12244?

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:

• Patches conform to the coding conventions.
• Any changes that could be relevant to users have been recorded in the changelog.
  • Is the change significant? If so, remember to add significance: significant in the changelog file.
• The documentation has been updated, if necessary.
• Manual QA notes have been included.
• Tests have been added. (Ask for help if you don’t know how to write them! Ask for an exemption if tests are too complex for too little coverage!)

  ---

  This is an automatic backport of pull request Fix renameFileWithRetry leaving temporary files after copying #12246 done by Mergify.

[ffaf1]

Please, a moment of reflection before we merge this.
If we do, we are not releasing cabal-install only.

I am not saying that it is bad, I just want to have the consequences clear.

[ffaf1]

We have to release Cabal-syntax.

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-08-31 13:51 UTC · Rule: default · triggered by rule Put backports in the rebase+merge queue
• ❌ Checks failed · on draft merge queue: checking #12298 on 3.18 (4f8ce45) #12303
• 🚫 Left the queue — 2026-08-31 14:05 UTC · at c696d8df315b7837265c2048c3f375dc59c54c1c

This pull request spent 13 minutes 50 seconds in the queue, including 2 minutes 34 seconds running CI.

Waiting for

• any of: [🛡 GitHub branch protection]
  • check-neutral = Doctest Cabal
  • check-skipped = Doctest Cabal
  • check-success = Doctest Cabal
• any of: [🛡 GitHub branch protection]
  • check-neutral = Meta checks
  • check-skipped = Meta checks
  • check-success = Meta checks
• any of: [🛡 GitHub branch protection]
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
• any of: [🛡 GitHub branch protection]
  • check-neutral = Bootstrap post job
  • check-skipped = Bootstrap post job
  • check-success = Bootstrap post job
• any of: [🛡 GitHub branch protection]
  • check-neutral = Check sdist post job
  • check-skipped = Check sdist post job
  • check-success = Check sdist post job

All conditions

• any of [🛡 GitHub branch protection]:
  • check-neutral = Doctest Cabal
  • check-skipped = Doctest Cabal
  • check-success = Doctest Cabal
• any of [🛡 GitHub branch protection]:
  • check-neutral = Meta checks
  • check-skipped = Meta checks
  • check-success = Meta checks
• any of [🛡 GitHub branch protection]:
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
• any of [🛡 GitHub branch protection]:
  • check-neutral = Bootstrap post job
  • check-skipped = Bootstrap post job
  • check-success = Bootstrap post job
• any of [🛡 GitHub branch protection]:
  • check-neutral = Check sdist post job
  • check-skipped = Check sdist post job
  • check-success = Check sdist post job
• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • Backport #12246: Fix renameFileWithRetry leaving temporary files after copying #12298
• github-review-approved [🛡 GitHub branch protection]
  • Backport #12246: Fix renameFileWithRetry leaving temporary files after copying #12298
• any of [🛡 GitHub branch protection]:
  • check-success = docs/readthedocs.org:cabal
  • check-neutral = docs/readthedocs.org:cabal
  • check-skipped = docs/readthedocs.org:cabal
• any of [🛡 GitHub branch protection]:
  • check-success = whitespace
  • check-neutral = whitespace
  • check-skipped = whitespace
• any of [🛡 GitHub branch protection]:
  • check-success = Changelogs
  • check-neutral = Changelogs
  • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

• docs/readthedocs.org:cabal
• whitespace
• Check sdist post job
• Changelogs

Failing checks:

• ❌ Check sdist post job (job log)
• 🟠 Doctest Cabal (job log)
• 🟠 Meta checks (job log)

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

[zlonast]

@Mergifyio queue

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-09-01 04:35 UTC · Rule: default · triggered by @zlonast with the @mergifyio queue command
• ❌ Checks failed · on draft merge queue: checking #12298 on 3.18 (4f8ce45) #12308
• 🚫 Left the queue — 2026-09-01 04:54 UTC · at c696d8df315b7837265c2048c3f375dc59c54c1c

This pull request spent 19 minutes 8 seconds in the queue, including 8 minutes 36 seconds running CI.

Waiting for

• any of: [🛡 GitHub branch protection]
  • check-neutral = Doctest Cabal
  • check-skipped = Doctest Cabal
  • check-success = Doctest Cabal
• any of: [🛡 GitHub branch protection]
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
• any of: [🛡 GitHub branch protection]
  • check-neutral = Bootstrap post job
  • check-skipped = Bootstrap post job
  • check-success = Bootstrap post job

All conditions

• any of [🛡 GitHub branch protection]:
  • check-neutral = Doctest Cabal
  • check-skipped = Doctest Cabal
  • check-success = Doctest Cabal
• any of [🛡 GitHub branch protection]:
  • check-neutral = Validate post job
  • check-skipped = Validate post job
  • check-success = Validate post job
• any of [🛡 GitHub branch protection]:
  • check-neutral = Bootstrap post job
  • check-skipped = Bootstrap post job
  • check-success = Bootstrap post job
• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • Backport #12246: Fix renameFileWithRetry leaving temporary files after copying #12298
• github-review-approved [🛡 GitHub branch protection]
  • Backport #12246: Fix renameFileWithRetry leaving temporary files after copying #12298
• any of [🛡 GitHub branch protection]:
  • check-success = Meta checks
  • check-neutral = Meta checks
  • check-skipped = Meta checks
• any of [🛡 GitHub branch protection]:
  • check-success = docs/readthedocs.org:cabal
  • check-neutral = docs/readthedocs.org:cabal
  • check-skipped = docs/readthedocs.org:cabal
• any of [🛡 GitHub branch protection]:
  • check-success = whitespace
  • check-neutral = whitespace
  • check-skipped = whitespace
• any of [🛡 GitHub branch protection]:
  • check-success = Check sdist post job
  • check-neutral = Check sdist post job
  • check-skipped = Check sdist post job
• any of [🛡 GitHub branch protection]:
  • check-success = Changelogs
  • check-neutral = Changelogs
  • check-skipped = Changelogs

Reason

The merge conditions cannot be satisfied due to failing checks

• Meta checks
• docs/readthedocs.org:cabal
• Bootstrap post job
• whitespace
• Check sdist post job
• Changelogs

Failing checks:

• ❌ Bootstrap post job (job log)
• 🟠 Doctest Cabal (job log)

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

[zlonast]

Also #12307 (comment)

[zlonast]

https://github.com/Mergifyio queue

[mergify]

Merge Queue Status

• ✅ Entered queue — 2026-09-01 12:08 UTC · Rule: default · triggered by @zlonast with the @mergifyio queue command
• ✅ Checks passed · on draft merge queue: checking #12298 on 3.18 (6cd54b3) #12312
• ✅ Merged — 2026-09-01 14:31 UTC · at af0302b8d91439f6806c8c0c709d393ff049892f · merge

This pull request spent 2 hours 23 minutes 36 seconds in the queue, including 2 hours 11 minutes 37 seconds running CI.

Required conditions to merge

• #review-threads-unresolved = 0 [🛡 GitHub branch protection]
  • Backport #12246: Fix renameFileWithRetry leaving temporary files after copying #12298
• github-review-approved [🛡 GitHub branch protection]
  • Backport #12246: Fix renameFileWithRetry leaving temporary files after copying #12298
• any of [🛡 GitHub branch protection]:
  • check-success = Doctest Cabal
  • check-neutral = Doctest Cabal
  • check-skipped = Doctest Cabal
• any of [🛡 GitHub branch protection]:
  • check-success = Meta checks
  • check-neutral = Meta checks
  • check-skipped = Meta checks
• any of [🛡 GitHub branch protection]:
  • check-success = Validate post job
  • check-neutral = Validate post job
  • check-skipped = Validate post job
• any of [🛡 GitHub branch protection]:
  • check-success = docs/readthedocs.org:cabal
  • check-neutral = docs/readthedocs.org:cabal
  • check-skipped = docs/readthedocs.org:cabal
• any of [🛡 GitHub branch protection]:
  • check-success = Bootstrap post job
  • check-neutral = Bootstrap post job
  • check-skipped = Bootstrap post job
• any of [🛡 GitHub branch protection]:
  • check-success = whitespace
  • check-neutral = whitespace
  • check-skipped = whitespace
• any of [🛡 GitHub branch protection]:
  • check-success = Check sdist post job
  • check-neutral = Check sdist post job
  • check-skipped = Check sdist post job
• any of [🛡 GitHub branch protection]:
  • check-success = Changelogs
  • check-neutral = Changelogs
  • check-skipped = Changelogs