Conversation
mydea
added this pull request to stack #19507
September 18, 2026 11:29
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 18, 2026
mydea
force-pushed
the
guide-cat/18-remove-connect
branch
from
September 21, 2026 07:18
ebb2078 to
96d57a8
Compare
mydea
marked this pull request as ready for review
September 21, 2026 07:23
chargome
approved these changes
Sep 21, 2026
mydea
force-pushed
the
guide-cat/18-remove-connect
branch
from
September 21, 2026 08:07
96d57a8 to
84b6649
Compare
mydea
force-pushed
the
guide-cat/18-remove-connect
branch
from
September 21, 2026 08:18
84b6649 to
44159cb
Compare
mydea
force-pushed
the
guide-cat/18-remove-connect
branch
from
September 21, 2026 08:30
44159cb to
8203694
Compare
mydea
force-pushed
the
guide-cat/18-remove-connect
branch
from
September 21, 2026 09:04
8203694 to
ac74eb6
Compare
Comment on lines
590
to
+593
| const userDocsRedirects = [ | ||
| // Connect guide removed (SDK no longer supports Connect) → Node | ||
| { | ||
| source: '/platforms/javascript/guides/connect/:path*', |
Contributor
There was a problem hiding this comment.
Bug: Hard-coded links in the metrics and logs getting-started guides point to old connect paths. The new redirect rule sends users to non-existent pages, causing a 404 error.
Severity: HIGH
Suggested Fix
Update the hard-coded url props in /docs/product/metrics/getting-started/index.mdx and /docs/product/logs/getting-started/index.mdx. The links should point to the correct, existing pages within the /platforms/javascript/guides/node/ path, or be removed if no equivalent guide exists.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: redirects.js#L590-L593
Potential issue: The pull request introduces a redirect from
`/platforms/javascript/guides/connect/:path*` to
`/platforms/javascript/guides/node/:path*`. However, it fails to update hard-coded links
in two getting-started guides: `/docs/product/metrics/getting-started/index.mdx` and
`/docs/product/logs/getting-started/index.mdx`. These links still point to the old
`connect` paths. When a user clicks them, the redirect rule correctly fires but sends
them to non-existent pages (`/platforms/javascript/guides/node/metrics/` and
`/platforms/javascript/guides/node/logs/`), resulting in a 404 error and a broken user
flow.
Did we get this right? 👍 / 👎 to inform future reviews.
mydea
removed this pull request from stack #19507
September 22, 2026 13:07
mydea
added this pull request to stack #19556
September 22, 2026 13:08
The Sentry JavaScript SDK no longer supports the Connect framework, so remove its guide and the Connect integration page, and strip `javascript.connect` from every supported/notSupported list and platform sample across the docs. - Delete `guides/connect/` and `configuration/integrations/connect.mdx`. - Remove `javascript.connect` from 46 frontmatter/JSX support lists. - Repoint the two product getting-started samples that used `platform="javascript.connect"` to `javascript.node`. - Redirect `/platforms/javascript/guides/connect/*` → the Node guide (Connect's former fallbackGuide). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
guide-cat/18-remove-connect
branch
from
September 22, 2026 13:22
ac74eb6 to
94c4f62
Compare
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
The Sentry JavaScript SDK no longer supports the Connect framework, so remove its guide and the Connect integration page, and strip
javascript.connectfrom every support list across the docs.guides/connect/andconfiguration/integrations/connect.mdx.javascript.connectfrom 46 frontmatter/JSX support lists.platform="javascript.connect"tojavascript.node./platforms/javascript/guides/connect/*→ the Node guide (Connect's former fallbackGuide).IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code