Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
chargome
left a comment
There was a problem hiding this comment.
Is this one not also relevant for browser? e.g. oofline caching is also interesting for a nextjs app right?
695a2b7 to
1b02aa8
Compare
1b02aa8 to
f949284
Compare
f949284 to
21183ab
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 21183ab. Configure here.
| - javascript.nitro | ||
| - javascript.nestjs | ||
| supportedCategories: | ||
| - browser-only |
There was a problem hiding this comment.
Parent hide orphans child pages
Medium Severity
Scoping the Special Use Cases index to browser-only drops that sidebar folder on meta-frameworks and other non-browser-only platforms. Child pages that stay published—including Next.js deploying-on-cloudflare, plus unrestricted sentry-testkit and web-workers—lose their nav entry because a missing parent is omitted from the sidebar tree.
Reviewed by Cursor Bugbot for commit 21183ab. Configure here.
21183ab to
42557f6
Compare
The Special Use Cases overview and its browser-specific guides (Micro Frontends, Shared Environments / Browser Extensions, Offline Caching, Multiple Sentry Instances) are relevant only to browser SPAs, not to meta-frameworks or backends. Replace the partial (and stale) backend `notSupported` lists with `supportedCategories: [browser-only]`. - Excludes meta-frameworks (astro, nextjs, nuxt, remix, …) and all server runtimes, which the previous hand-maintained lists did inconsistently (they excluded the 13 original Node backends but still rendered on bun, cloudflare, deno, elysia, firebase, and mastra). - Offline Caching additionally keeps its explicit `notSupported` (capacitor, cordova, electron, wasm). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
42557f6 to
6d54dd9
Compare
right, I will make offline caching browser instead of browser-only! |
Use the broader `browser` category instead of `browser-only` for the Special Use Cases overview and Offline Caching, so meta-framework guides (which have browser-relevant sub-pages) also render these pages. Offline Caching keeps its explicit notSupported list (capacitor, cordova, electron, wasm). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
| supportedCategories: | ||
| - browser |
There was a problem hiding this comment.
Bug: Inconsistent supportedCategories between the parent index page (browser) and child pages (browser-only) will cause some documentation pages to be hidden for meta-framework users.
Severity: LOW
Suggested Fix
To ensure all child pages are visible for meta-framework guides, update the supportedCategories frontmatter in the affected child pages from [browser-only] to the broader [browser] category. This will align them with the parent index page and prevent them from being filtered out during the build process for platforms that don't define the browser-only category.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: docs/platforms/javascript/common/best-practices/index.mdx#L6-L7
Potential issue: There is an inconsistency in the `supportedCategories` frontmatter
property between a parent documentation page and its children. The parent index page for
'Special Use Cases' is assigned `supportedCategories: [browser]`, while several of its
child pages are assigned `supportedCategories: [browser-only]`. For meta-framework
platforms (e.g., Next.js) that do not include `browser-only` in their platform
categories, the build process will filter out these child pages. This results in a
degraded user experience where the index page is visible but appears incomplete, as it
will be missing links to the filtered-out child pages.
Also affects:
docs/platforms/javascript/common/best-practices/micro-frontends.mdx:5~6docs/platforms/javascript/common/best-practices/shared-environments.mdx:5~6docs/platforms/javascript/common/best-practices/multiple-sentry-instances.mdx:5~6
Did we get this right? 👍 / 👎 to inform future reviews.
coolguyzone
left a comment
There was a problem hiding this comment.
LGTM, please resolve the issue brought up by the review bot.


DESCRIBE YOUR PR
The Special Use Cases overview and its browser-specific guides (Micro Frontends, Shared Environments / Browser Extensions, Offline Caching, Multiple Sentry Instances) are relevant only to browser SPAs. Replace their partial, stale backend
notSupportedlists withsupportedCategories: [browser-only].notSupported(capacitor, cordova, electron, wasm).sentry-testkitintentionally left unrestricted (a transport-override testing tool usable in browser or Node tests).IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code