Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
mydea
added this pull request to stack #19507
September 18, 2026 11:29
6 tasks
mydea
marked this pull request as ready for review
September 21, 2026 07:23
chargome
approved these changes
Sep 21, 2026
mydea
force-pushed
the
guide-cat/17-server-integration-matrix
branch
from
September 21, 2026 08:07
959316e to
bcb3b23
Compare
mydea
force-pushed
the
guide-cat/17-server-integration-matrix
branch
from
September 21, 2026 08:18
bcb3b23 to
22e96cc
Compare
Comment on lines
1
to
8
| --- | ||
| title: Postgres.js | ||
| description: "Adds instrumentation for the postgres (postgres.js) library." | ||
| supported: | ||
| - javascript.cloudflare | ||
| - javascript.deno | ||
| supportedCategories: | ||
| - server | ||
| --- | ||
|
|
||
| <AvailableSince version="10.41.0" /> |
Contributor
There was a problem hiding this comment.
Bug: The documentation for the postgresjs integration is incorrectly shown for Node.js and Bun runtimes, where the integration is not actually supported.
Severity: LOW
Suggested Fix
Update the supportedCategories in postgresjs.mdx to accurately list only the supported runtimes, such as ['deno', 'cloudflare'], instead of the general [server] category. This will ensure the documentation is only visible for platforms where the integration is available.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location:
docs/platforms/javascript/common/configuration/integrations/postgresjs.mdx#L1-L8
Potential issue: The change to `supportedCategories: [server]` in the `postgresjs.mdx`
file incorrectly makes the documentation for the `postgresjs` integration visible for
all server runtimes, including Node.js and Bun. However, the `instrumentPostgresJsSql`
integration is not supported on these platforms; it is only available for Deno and
Cloudflare. This inconsistency will mislead users on Node.js and Bun into thinking the
feature is available to them, causing confusion and potential implementation errors when
they find it doesn't work.
Did we get this right? 👍 / 👎 to inform future reviews.
mydea
force-pushed
the
guide-cat/17-server-integration-matrix
branch
from
September 21, 2026 08:30
22e96cc to
274754e
Compare
mydea
force-pushed
the
guide-cat/17-server-integration-matrix
branch
from
September 21, 2026 09:04
274754e to
1822f74
Compare
mydea
removed this pull request from stack #19507
September 22, 2026 13:07
mydea
added this pull request to stack #19556
September 22, 2026 13:08
These integrations are exported from `@sentry/node` (and re-exported by the edge runtimes that support them), so they are available across all server SDKs rather than the handful of frameworks the hand-maintained lists enumerated. Move them to `supportedCategories: [server]` with the runtimes the SDK does not support listed under `notSupported`, verified against the exports in getsentry/sentry-javascript. - childProcess: node-only → exclude bun, deno, cloudflare (keep electron). - fastify: node+bun → exclude deno, cloudflare. - koa: node+bun+deno → exclude cloudflare. - hapi: node+bun+deno → exclude cloudflare. - postgresjs: node+bun+deno → exclude cloudflare (the previous list wrongly listed only cloudflare/deno and omitted node/bun). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These integrations are also available on the edge runtimes, so drop the notSupported runtime exclusions and let them show across all server SDKs: - fastify: also available on deno and cloudflare. - hapi: also available on cloudflare. - koa: also available on cloudflare. - postgresjs: also available on cloudflare. Remove the "only works in Node.js and Bun runtimes" alerts from fastify, hapi, and koa, which no longer hold. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
force-pushed
the
guide-cat/17-server-integration-matrix
branch
from
September 22, 2026 13:22
1822f74 to
5d85424
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Several Node/framework integrations were pinned to a handful of frameworks in hand-maintained lists even though the SDK exports them across server runtimes. Move them to
supportedCategories: [server], listing only the runtimes the SDK genuinely does not support undernotSupported, verified against getsentry/sentry-javascript.connectIntegrationdoes not exist andnestIntegrationis@sentry/nestjs-only (connect removal handled in the next PR).IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code