Repository navigation
fix: audit fixes and per-tab colors - #367
Merged
Merged
Conversation
…tion Covers M5 from docs/audits/codebase-audit-2026-09-28.md: a session whose child ignores SIGHUP must still be reaped by session.close(kill: true) instead of returning Timeout and leaving the process running. Currently red against the unfixed close path (no SIGKILL escalation).
This was referenced Sep 28, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Fixes the findings from the September codebase audit and adds color coding for pane tabs.
programa notifyposts to the workspace you name instead of the one you ran it from.session.closeno longer stalls a worker thread, and kills sessions that ignore SIGHUP.Review order
Sources/TabItemView.swift(sidebar menu) andvendor/bonsplit+Sources/Workspace*.swift(tab colors)Sources/TerminalController.swift(threading change)core/crates/programad(daemon close)Localizable.xcstringsis dataTest plan