Repository navigation
fix: unblock CI after the audit-fix merge - #368
Merged
Merged
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
CI on main went red after #367 merged, so the new build never shipped. Two gates failed, neither of them a test:
cargo fmt --checkrejected two programad files from the daemon close fix. This took downshared-coreandwindows-build.Sources/TerminalController.swiftcame out one line over its structural budget (3022 vs 3021). This took downchange-detection, andunit-testswas skipped because of it.This PR runs rustfmt on the two files and deletes a duplicated blank line in TerminalController. No behavior changes.
Test plan
shared-core,windows-build, andchange-detectionpassunit-testsshards run and pass