Repository navigation
fix: restore browser automation and fix the new restore test - #370
Merged
Merged
Conversation
The nonisolated socket chain ran every browser method on main, so browser.wait blocked the main thread it was waiting on and timed out.
…ore test Selecting a folder child in the live app expands the folder, so the test never reached the collapsed state it asserts on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
With the gates fixed (#368), CI on main got to the tests and two failed. Both came from #367.
browser.waittimed out on every attempt. The socket isolation change routed all browser commands through the main thread, andbrowser.waitblocks while it polls the page, so it blocked the thread the page needed. This reverts that change; browser commands run on the socket thread again, exactly as before fix: audit fixes and per-tab colors #367. The compiler warning that change targeted comes back, and it needs a proper fix: making the browser handlers themselves nonisolated.Test plan
socket-integration-testspasses, includingtest_cli_browser_console_errors_text.pyunit-testspasses (TabManagerSessionSnapshotTests: 10/10 locally)