Repository navigation
fix(hub): bundle workspace tool runner before sandbox startup - #115
Merged
Merged
Conversation
This was referenced Nov 3, 2026
|
Open an issue for this change first, then a pull request that links it. |
TheGreatAxios
requested changes
Nov 3, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
The pre-sandbox bundle is the right fix for the package lookup. One leftover from the old entry path: the sandbox still allow-reads apps/hub/src/builds for a reason that no longer applies. Detail is on the new child command.
Not asking for the other items that came up while reading this:
- Rebuilding on each
createPosixBuildExecutoris real, but it is once per executor (sidecar lease or live-app start), not per tool call, and a warm build is tens of milliseconds. Memoizing it can wait. - Do not fail the new isolation test when
CIis set. The requiredtestjob isubuntu-24.04with onlybun install. bubblewrap, socat, andkernel.apparmor_restrict_unprivileged_userns=0are set up one2e-pipeline, which does not run this file and iscontinue-on-error. A hard fail would redteston every apps change. The skip is why that job stays green; the test simply does not gate CI today. - Leave
minify: truewith no sourcemap. An unminified bundle or an inline sourcemap puts repository paths back into a file the sandbox is allowed to read.
Bundle posix-child.ts and its dependencies before entering the sandbox. Run the bundle with Bun so tool startup no longer needs repository-wide package discovery that the sandbox correctly blocks. This affects tool calls for design process.
etodanik
force-pushed
the
fix/posix-child-prebuild
branch
from
November 3, 2026 19:26
52ca312 to
46eb519
Compare
The bundled tool runner no longer needs to read the hub source directory. Remove that allowlist entry and verify source reads are denied in the existing sandbox behavior test.
![corbits-triage[bot]](https://avatars.githubusercontent.com/u/275831056?s=60&v=4){kind=small}
TheGreatAxios
enabled auto-merge
November 4, 2026 01:08
TheGreatAxios
approved these changes
Nov 4, 2026
|
Triage: Pass No changes needed from you. A maintainer will review this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Designers could not read project documents or create mockups because the
sandboxed tool runner failed to resolve @intx/tools-posix. The package
was installed, but Bun's workspace package lookup required access to
repository paths outside the sandbox's read policy.
Bundle the trusted tool runner and its dependencies before isolation,
then execute that bundle inside the existing sandbox. This removes
runtime package discovery without expanding filesystem or network access.
Add a sandbox behavior test that verifies:
Fixes #123