Repository navigation
Conversation
End the live reply on connector.reply so a missed message-end frame cannot leave the thinking indicator active. Add one regression test covering completion, text preservation, and thinking restarting for the next generation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thinking indicator could remain active after a coordinator reply if the following message-end frame was missed. End the UI's live reply on
connector.reply, preserving text until the durable transcript catches up.Add one regression test covering completion without the end frame, preservation of reply text, and the next generation starting. This changes only the UI reducer and its test.
Stacked on #115; base branch:
fix/posix-child-prebuild.Closes #118.
Validation:
git diff --checkpass.vendor/interchange/data/.