Repository navigation
fix(web): stop thinking when the coordinator replies - #120
Merged
Merged
Conversation
corbits-triage
Bot
added
Triage: Ready
focused: check
Triage: Waiting for CI
and removed
Triage: Ready
labels
End the live reply on connector.reply so a missed message-end frame cannot leave the thinking indicator active. Add one regression test covering completion, text preservation, and thinking restarting for the next generation.
etodanik
force-pushed
the
codex/stop-thinking-on-reply
branch
from
November 3, 2026 16:26
9f1d472 to
372a454
Compare
corbits-triage
Bot
added
Triage: Ready
and removed
Triage: Waiting for CI
focused: check
labels
TheGreatAxios
requested changes
Nov 3, 2026
TheGreatAxios
left a comment
TheGreatAxios
left a comment
Contributor
There was a problem hiding this comment.
One bug in the new terminal fold. Treating connector.reply as completion is right when the end frame never arrives, but that end frame is the normal path, not only the miss. It stamps a later endedAt, so a send between the two frames hides the thinking mark until the next run starts. Comment is on the diff.
Nothing else in this change looks wrong. Keeping the first end time still lets the next generation think: inference.start and message.run.started clear ended before the following reply stamps a new time.
Keep the first terminal timestamp when duplicate completion frames arrive, so an old message end cannot clear a newer send's waiting indicator. Cover duplicate completion and the next generation with a controlled clock.
|
Triage: Fail Waiting on:
Stacked on #115: only this pull request's own changes were checked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thinking indicator could remain active after a coordinator reply
if the following
message.run.endedframe was missed.Treat
connector.replyas completion in the existing UI reducer.Keep reply text visible until the durable transcript catches up,
and allow thinking to restart for the next generation.
Changes are limited to the UI reducer and one regression test.
Stacked on #115.
Closes #118.