Repository navigation
fix(runtime): attribute MinIO and gateway to their parent service - #117
Merged
Merged
Conversation
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local MinIO and gateway containers previously exposed only suffixed runtime names, so the CLI could not prove their loaded parent service during repeated runtime setup. Both constructors now supply
s.Identitythrough Core'sDockerEnvironment.WithServiceIdentitybefore first use. Core owns exact label encoding/validation; CLI retains its independent scope, name and port checks.Classification: fix at the producer by consuming the shared owner API. No name inference, second attribution mechanism or broad cleanup is added.
README.mddocuments exact parent labels, credential-driven replacement with retained data, and the explicit recovery limits for older unlabeled containers. The custody test now checks lifecycle response statuses and both generations' exact labels, bytes and complete metadata.Final reviewed source f913495 selects Core bc4e15ca through
codefly agent deps --pin, without workspace overrides. Supported standalone build, vet and tidy checks pass. Local unit/race suite passes; a gateway image built from this exact tree passes selected real PutGet and retained-data custody e2e in 91.165s with no selected skips. Exact-head CI passes build/test, race, integration-minio, full agent-runtime-e2e and image-sbom. Independent initial and changed-pin reviews accept the implementation; source reports remain available in/tmp/core858-objectstorage-review.mdand/tmp/core858-consumer-provenance-followup.md.Earlier qualification's initial IPv6 loopback readiness failure remains unexplained; its unchanged retry and the final exact-image run pass, and no unsupported contention diagnosis is claimed. Root separately proved repeated CLI-driven retained-data behavior with the previous owner candidate. This PR qualifies source integration, not the new stable agent/gateway artifacts. Stable Core pin, merged-ref gateway image publication/lock adoption and agent release verification follow the existing owner tools. Real S3/GCS/Azure and cloud deployment were not exercised.