Repository navigation
feat(environment): product profile import and hosted build fixes - #1117
Open
crisfiorini-oss wants to merge 6 commits into
Open
crisfiorini-oss wants to merge 6 commits into
crisfiorini-oss wants to merge 6 commits into
Conversation
12 tasks
crisfiorini-oss
marked this pull request as draft
October 26, 2026 20:57
crisfiorini-oss
force-pushed
the
feat/azure-key-vault-secrets
branch
from
October 28, 2026 16:04
3ea67a1 to
14172ae
Compare
crisfiorini-oss
marked this pull request as ready for review
October 28, 2026 16:51
crisfiorini-oss
marked this pull request as draft
October 28, 2026 16:58
crisfiorini-oss
marked this pull request as ready for review
October 28, 2026 17:10
crisfiorini-oss
marked this pull request as draft
October 28, 2026 17:58
The CLI consumes infra-base outputs and stays cloud-neutral. Remove the Azure Key Vault secret store and release signer, the Azure credential helper, the Azure SDK, and the planner-input export/publisher image that existed only for them. Also drop changes nothing consumes: the `deploy gitops cell` verb, the --supplied/--mint planner flags, draft promotion PRs, and the Cloud KMS error-classification change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GehdohoEWY15W4Vj1EBoox
crisfiorini-oss
force-pushed
the
feat/azure-key-vault-secrets
branch
from
October 28, 2026 21:24
f76ef7b to
14b0a3f
Compare
crisfiorini-oss
marked this pull request as ready for review
October 28, 2026 21:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloud-neutral CLI changes that hosted delivery needs. The CLI consumes infra-base outputs and knows nothing about a specific cloud: following review on 2026-10-28, all Azure-specific code was removed from this PR.
Changes
codefly environment import:--configuration-sourceand--configuration-profileslet the product select its configuration profile when the coordinate contract from infra-base is placement-only. A value that conflicts with the contract is refused. infra-base#1494 and platform-obin#220 use these flags. Profile reads are confined with the standard library'sos.Root, and pinned modules are resolved before validation.<module>/<service>service-secrets entry is selected before the unqualified<service>one, matching service configuration and identity. Workspace validation checks the selected environment.docs/cli-reference.mdis marked generated in.gitattributes.Removed after review
deploy secrets --export-input/--input) and the publisher image, which existed only for the Azure store.deploy gitops cellverb,deploy secrets --supplied/--mintand the related planner changes, draft promotion PRs, and a Cloud KMS error-classification change.Testing
Before merging main:
go build ./...,go vetandgolangci-lint(0 issues) on the changed packages; tests passed forcmd/environment,pkg/environments, and the projection, frontend, cache and builder tests inpkg/gitopsandpkg/orchestration. The command reference was regenerated withgo test ./cmd -run TestCLIReferenceIsCurrent -update-reference.Main merged cleanly with the same diff. The local rebuild after the merge ran out of devbox disk, so CI covers it. Three
pkg/solutionrunfrontend tests fail only on the devbox ("not a git repository" in a temp directory); this PR does not change those tests.🤖 Generated with Claude Code
https://claude.ai/code/session_01GehdohoEWY15W4Vj1EBoox
Generator qualification follow-up
The review finding about
--input --rotateis no longer applicable: the planner-input mode was removed in this PR. The generate qualification step now passes the workflow's read-only GitHub token to Core's existing agent release lookup and downloader. This addresses unauthenticated API rate limits without skipping tests or changing the qualification gates. A failed release lookup falls back to the test's isolated local agent directory, which can surface as a missing-file error.GITHUB_TOKENfor release lookup and verified download. Reuse that mechanism; do not add an agent cache, downloader or alternate fixture.After rebasing onto main:
git diff --checkandgo test ./pkg/conformance -run 'Test.*(Generate|Workflow|Packages)' -count=1passed. Full suites run in pull request CI.