Skip to content

fix(run): retain hosted frontend reload and dependency installation state - #1270

Open
gael-obin wants to merge 1 commit into
codefly-dev:mainfrom
gael-obin:fix/hosted-frontend-reload-review-20261102
Open

gael-obin wants to merge 1 commit into
codefly-dev:mainfrom
gael-obin:fix/hosted-frontend-reload-review-20261102

Conversation

@gael-obin

@gael-obin gael-obin commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Local hosted frontend changes could remain stale or recover with the wrong installed dependency contents. This preserves the existing controller, delivery and staging mechanisms while watching frontend sources, serializing delivery, scoping recovery, and tracking the actual successful installation separately from the retained bundle.

Classification: fix at the CLI lifecycle/build owner. The installation digest covers manifests, locks, npm configuration, tarballs and local directory package contents. Failed or interrupted installations lose their marker; reverting dependencies after failed build/retention does not reuse a stale installation. Source-only edits can reuse installed dependencies.

This is the 26-file additional delta from the locally exercised v2 controller source, over current main 43b05672. It excludes the stray .orig backup and the three setup files already in setup delivery. The selected local cohort also needs Core setup, native loopback mapping, and the linked Core watcher PR. New main's service-secret changes are preserved.

Validation retained from the exact selected cohort: real npm regression tests with/without locks, source-only reuse, failure/revert/cancellation cases; go test -race for pkg/solutionrun, cmd/run and pkg/engine; CLI build; actual persistent controller use. All 1,904 source hashes were rechecked. These are prior combined-cohort results, not a clean current-main CI pass.

Merge/release qualification remains blocked until compatible dependency pins and current combined checks are qualified. Hosted delivery work overlaps the npm build-command line and docs but does not replace installation identity/watch lifecycle. Preserve and reconcile it. Process-wide launch attribution for concurrent embedded hosts remains a documented limitation; automatic recovery is not a universal concurrency guarantee.

Shared watcher implementation: Core recovery.

Initial bootstrap CI fails because the committed Core dependency does not yet provide code.WatchTree. Adopt a qualified release containing the watcher owner change, then rerun. Local workspace testing is not a substitute for that published dependency.

CI and review follow-up

Opened for review at the author’s request. Removing draft status does not certify merge or release readiness. This follow-up inspected the published head and logs; it made no implementation changes and did not rerun tests.

Compilation fails because the committed Core dependency lacks code.WatchTree, the new NewWatcher signature, and Change.Err. Native qualification, generation, bootstrap and lint logs confirm the API mismatch; cancelled suites are unqualified. The Core watcher PR must be qualified and adopted through a compatible dependency selection before these checks can pass.

No submitted GitHub reviews, inline review comments, or conversation comments were present in the captured state. Independent publication/status audits are scoped evidence, not owner approval.

Failed jobs inspected:

…tate

Publish the previously exercised owner implementation for draft review.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant