Repository navigation
media: apple: prores: hardware ProRes decode on every APR engine, several jobs in the ring - #2620
RyanTheTide wants to merge 18 commits into
Conversation
Add a compatible-gated stateful decoder alongside the existing encoder. Validate complete ProRes frames and pack the 0x100-byte non-RAW descriptor. Share the APR ring with generation-aware variable-size accounting. Snapshot completion diagnostics before the W1C/tail handoff. Preserve reset-based timeout recovery. Cover descriptor layout, parser bounds, and mixed ring wrap with KUnit. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Apple lists each ProRes engine in its SoCs as a ProRes encode and decode engine, and the decode descriptor runs on the same ring as the encoder's. The decoder node was registered only on the T6000 and T8140 variants. Register it for every compatible the driver binds (T6041 and T6050 as well) and drop the per-variant flag. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
The decoder parsed a source frame three times per job: in buf_queue for the source-change check, in job_ready and in device_run. Each parse walks the whole slice-size table (1020 entries for a 1080p frame, 4080 at 2160p) with 16-bit loads from the vb2 dma-contig mapping, which is uncached because the engine is not DMA-coherent, so every entry is a round trip to memory. job_ready also runs in atomic context, from v4l2_m2m_job_finish() in the completion interrupt. With one job in the ring this time sits between the interrupt and the next job. On an M1 Pro (T6000), function_graph shows 76 us per parse of a 1080p ProRes 422 HQ frame and 304 us at 2160p, three times per frame, and the engine idles 100 us (1080p) and 331 us (2160p) between jobs. Parse the frame once, in buf_prepare, and keep the result with the buffer. A frame that does not parse still fails its own job rather than QBUF, as before. Copy the slice table in 256-byte blocks and check the copy, so the CPU reads it with wide loads: one parse now takes 9 us at 1080p and 61 us at 2160p, and the gap between jobs is 3-5 us. Decode throughput on the M1 Pro, depth 1, same clips, output unchanged byte for byte: 1080p 422 HQ 1870 -> 2780 fps, 2160p 422 HQ 495 -> 765 fps, 1080p 4444 1470 -> 1880 fps. Add a KUnit case with a 1080p table that spans several blocks, with a bad entry in the first full and the last partial block. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
The engine works through a producer/consumer descriptor ring, but the driver kept one job in it: v4l2-m2m runs one job at a time and the job only finished at its completion interrupt. On an M1 Pro, VideoToolbox decodes the same clips about 2.6 times faster on the same engine, and between two of our jobs the engine sits idle for the interrupt and the workqueue round trip to the next device_run (100 us per 1080p frame). Publish a job's descriptor, move its buffers off the m2m queues into a per-device FIFO tagged with the ring pointer past the descriptor, and finish the m2m job at once so the next one is prepared while the engine works. Up to APR_MAX_INFLIGHT (8) jobs sit in the ring; when it is full the m2m job stays running until a completion makes room, so device_run is only entered with room for one more descriptor. The interrupt reads the tail and completes, in ring order, every job the tail has passed. DONE and ERROR are latched per engine, so an ERROR fails every job in the ring at that moment. A ring that stops moving for a second fails all of its jobs and resets the engine as before; device_run waits for that reset. stop_streaming, suspend and a STOP command with an empty OUTPUT queue wait for the context's jobs in the ring; job_abort marks only that context's jobs cancelled, since encoder and decoder share the ring. Encode stays at one job in the ring: every encode job uses the one shared statistics area and encode already runs at macOS speed. Add KUnit cases for the ring distance, free space, tail validation and in-order retirement across the ring wrap, and for the FIFO limits. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
With several decode jobs in the ring, the driver gave a job's buffers back once the consumer tail had passed its descriptor. The tail moves when the engine fetches a descriptor, not when the frame is written, so buffers went back to vb2 while the engine still wrote them: wrong output on 4:4:4 clips and DART faults at the end of a run. The engine reports the id of the last decode job it has finished in the upper half of ST1; the decode command word already carries a 16-bit id. Give decode jobs device-wide ids that skip 0 (ST1 reads 0 after a reset), read ST1 after the status clear, and retire decode jobs in ring order once their id is reported finished. An encode descriptor carries no id, so an encode only enters an empty ring and completes on its interrupt, as before. On an M1 Pro (T6000) with eight jobs in the ring every clip decodes to the same bytes as with one job, with no DART faults; 1080p 422 HQ goes from about 2730 to 2920 fps, 4K 422 HQ from 761 to 775 fps. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Several paths could still hand buffers back while the engine owned them or would use them: - A DONE or ERROR latched after the last job was retired by id stayed set. An encode published into the then empty ring was taken for finished on it, because the tail passes an encode as soon as it is fetched. The engine is idle while the ring is empty, so clear both status bits before publishing into an empty ring. - ST1 = 0 counted as "finished" for every id in 0x8001..0xffff, and an id not issued yet retired the whole ring. 0 now means no progress, and an id at or after the next one to issue marks the ring hung, so the watchdog resets the engine before any buffer goes back. - A job that fails before it reaches the ring (a frame that does not parse, an interlaced frame) completed at once, ahead of up to seven earlier frames of the same context. As the drain's last source buffer it sent LAST and EOS first and the frames still in the ring were lost. It now waits until the context's jobs in the ring are given back. - apr_finish_job() removed the source and destination buffers outside hw_lock, so a STOP could see the destination half moved. Move both under the lock, as device_run does. Also correct the watchdog comments (it fires when no job finishes, not when the tail stops) and the ring test comment. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
The decode descriptor has no input length, so the engine reads as far as the frame's own sizes take it. apr_parse_frame() already holds the frame size, frame and picture header sizes, picture sizes, slice table and slice sizes to the payload, but two in-band fields the engine may also follow were never checked: - the picture header's slice count, which could ask for more slice table entries than the picture geometry gives; - each slice header, whose coded Y and Cb sizes (and Cr size, with alpha) could run past the end of the slice and so, for the last slice, past the buffer. Accept a slice count of 0, which our encoder writes, or the count the geometry gives. Require every slice header to fit its slice (8 bytes with alpha, where the Cr size is explicit, 6 otherwise) and its coded component sizes to fit the rest of the slice. Every ffmpeg-made test clip and every frame from the hardware encoder passes these checks. Read each slice size once so that the parse itself stays inside the payload even if userspace rewrites the buffer while it runs. Give the KUnit fixture valid 6-byte slice headers. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
The decode descriptor carries no input length, so a frame must not get past apr_parse_frame() if any size the engine follows points beyond the queued payload. Add KUnit cases for frames that do: a picture size 1 byte, 64 KiB and 4 GiB past the buffer; a frame size larger than bytesused; a payload truncated by one byte; a frame header past the frame; a slice table ending past the picture; a slice count asking for more table entries; slice sizes summing one byte past the picture; slice headers whose coded sizes run past their slice; and a bottom-field picture or slice past the buffer. The exact-fit frame and one that ends on the boundary byte are accepted. Each frame is parsed from an allocation exactly as long as the payload, so with KASAN an over-read in the parser is reported as well. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
…parse-20261120 # Conflicts: # drivers/media/platform/apple/prores/apple-prores-desc.c # drivers/media/platform/apple/prores/apple-prores-test.c
…inflight-st1-20261120
The decoder sends V4L2_EVENT_SOURCE_CHANGE when the stream's size or chroma changes, but its OUTPUT format description only carried V4L2_FMT_FLAG_COMPRESSED. The uAPI defines V4L2_FMT_FLAG_DYN_RESOLUTION for a stateful decoder that does this. Without the flag, GStreamer's v4l2 decoder sets up the CAPTURE queue before the first event and then takes that event as a mid-stream resolution change. It mistakes the real end-of-stream LAST buffer for the end of that change and waits forever, so every v4l2proresdec pipeline hangs at EOS even though its output is complete. FFmpeg does not look at the flag. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
# Conflicts: # drivers/media/platform/apple/prores/Kconfig # drivers/media/platform/apple/prores/apple-prores-drv.c
|
Hardware row for this head (64b404a) against the stack before the integration merge (66099fc = a1ad1a8 + d409342). The merge changes nothing in decode: every clip decodes to the same SHA as before (and as the 11-20 rows), throughput is unchanged, and the drain, kill, two-context and out-of-bounds rows behave the same. M1 Pro (T6000), 7.3.0-aurora-fleet76; apple-prores.ko built W=1 out of tree for both revisions against the fleet76 tree and swapped in user space (rmmod/insmod), in-tree module restored after.
fps are N=3 interleaved runs. W=1 build: no warnings in drivers/media/platform/apple/prores. Assisted-by: LLM (Claude:Opus 5.5) |
|
Hardware row: M5 Pro MacBook Pro (J714s, T6050, ProRes codec Tested on M5 Pro (
Note: |
|
Merge-train adversarial review (MERGETRAIN-LINUX2) at 64b404a: BLOCKERS. Not merging until the blockers below are fixed or answered; the details give file:line and a failure case. Full review#2620 media: apple: prores: hardware ProRes decode on every APR engine, several jobs in the ring @64b404a4VERDICT: BLOCKERS Blockers
Nits (should fix)
Missing rows
|
|
Claude Opus 5.5 on @satchlj's behalf. J775c (Mac Studio M5 Max, T6050) rows at head Setup
Rows (all
Notes
Assisted-by: LLM (Anthropic:Claude Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR checklist review at live head 64b404a494cd559efad3184d2ef01cd7cf278eb3 (CI: 7/7 green; §1 no model gating, §2 default cmdline, §4 human commit attribution/SoB, §6 naming all clean).
Blockers
-
Source-buffer DMA-read TOCTOU across the shared APR DART (
drivers/media/platform/apple/prores/apple-prores-drv.c:2278-2289,drivers/media/platform/apple/prores/apple-prores-desc.c:526-554,:562-566)apr_buf_prepare()parses and validates the frame's in-band sizes once atQBUFtime and cachesbuf->info, whileapr_build_decode_desc()passesDD_INPUTwith no input length limit (the hardware decode descriptor carries none).- Because
OUTPUTusesVB2_MMAP | VB2_DMABUF, userspace retains write access to the buffer afterQBUFand while up to 8 jobs sit in the ring. Modifyingframe_size,picture_size, slice table entries, or slice header coded sizes afterQBUFlets the engine DMA-read past theOUTPUTbuffer into adjacent mappings in the shared APR DART (cross-context data leak from another user's encode/decode buffers) or into an unmapped IOVA (DART fault / engine reset DoS failing other contexts' in-flight jobs). - The comment at
apple-prores-desc.c:564-566protects only the CPU parser, not the DMA engine. - Fix: Copy the validated bitstream into a driver-owned DMA bounce buffer (or bounded pool of
APR_MAX_INFLIGHTprivate buffers) and parse that private copy before programmingDD_INPUT, or enforce a hardware input-length bound if one exists.
-
apr->hungrace breaks the reset-before-buffer-return invariant and allows submitting into a hung ring (drivers/media/platform/apple/prores/apple-prores-drv.c:1522-1577,:1623-1635,:1653-1671,:1766-1784)- When
apr_take_done()latchesapr->hung = true(invalid tail at:1566orAPR_DONE_ID_FUTUREat:1575),APR_REG_IRQ_ENABLEis not masked andapr_take_done()does not checkapr->hungon entry. - Even without a second interrupt,
apr_watchdog()unconditionally callsapr_take_done()at:1657whenapr->hungis alreadytrue. A secondapr_irq()orapr_watchdog()itself can retire jobs and hand buffers back to vb2 before the engine is reset; ifapr_irq()retires the remaining jobs (njobs == 0),apr_watchdog()returns early at:1653, skipping the reset and leavingapr->hung = truelatched for the next job. - Furthermore,
apr_device_run()(:1766) waits only onapr->resetting, notapr->hung. Ifheld == NULL(fewer than 8 jobs in flight), anotherapr_device_run()can acquirehw_lockbeforeapr_watchdogruns and publish a new descriptor into the hung ring. - Fix: Mask
APR_REG_IRQ_ENABLEimmediately when settingapr->hung = true; return early fromapr_take_done()(and skip calling it inapr_watchdog()) whenapr->hungis set; haveapr_device_run()wait onapr->hung || apr->resetting; ensureapr_watchdog()still performs the reset ifapr->hungis set.
- When
-
Broken mid-stream dynamic resolution change (
drivers/media/platform/apple/prores/apple-prores-drv.c:2004,:2052-2056,:2300-2339)- The decoder advertises
V4L2_FMT_FLAG_DYN_RESOLUTION(:2004), butapr_decode_source_change()fires immediately atQBUFtime without marking the last pre-changeCAPTUREbufferV4L2_BUF_FLAG_LAST(so userspace cannot drain old-resolution frames before reconfiguring). - Worse, when
vb2_is_busy(dst_vq)is true (always the case mid-stream),apr_decode_source_change()(:2319-2330) skips updatingctx->dst_fmt, andapr_stop_streaming()never refreshes it either. When userspace reacts toV4L2_EVENT_SOURCE_CHANGEwithSTREAMOFF(CAPTURE)->G_FMT(CAPTURE),apr_g_fmt_cap()(:2054) still returns the stale pre-change resolution, breaking standard V4L2 stateful DRC clients.
- The decoder advertises
Non-blocking notes / §5 remaining rows
- Stale docs/comments:
drivers/media/platform/apple/prores/Kconfig:25-26andapple-prores-desc.c:477still state decode is T6000/T8140-only, though7c55de42enables it on every APR variant. - Missing §5 rows at live head
64b404a4: T6000 (M1 Pro) and T6050 (J714s, J775c — including wrap, alpha, odd/wide encode, and in-flight s2idle) are covered; still missing live-head rows on T6041 (J616s), T8140 (Neo J700), and T8142 (J815), plus root-causing the occasionalcompletion found without an interruptwarning on T6050.
Assisted-by: LLM (Gemini 4 Neon)
When apr_take_done() finds a tail outside the ring or a finished id that was never issued, it marks the ring hung and queues the watchdog, which fails every job and resets the engine before their buffers go back. Four paths broke that order: - the engine interrupt stayed enabled, and apr_take_done() did not check the flag, so a second interrupt before the watchdog ran retired jobs by the untrusted ST1 id and handed their buffers back to vb2 while the engine might still use them; - the watchdog itself called apr_take_done() on a hung ring; - if that left the ring empty, the watchdog returned early, skipping the reset and leaving the flag set for the next job; - device_run only waited for a reset in progress, so a job could be published into the hung ring before the watchdog took the lock. Mask the engine interrupt when the ring is declared hung, take no completions while it is, and have the watchdog reset a hung ring even when no job is left in it. device_run now waits until the ring is neither hung nor being reset. A runtime suspend powers the engine off, which resets it, so it clears the flag too. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
The decode descriptor has no input length: the engine follows the frame's in-band sizes (frame and picture size, the slice table and each slice header). Those sizes were checked once, in buf_prepare, on the OUTPUT buffer itself, which userspace can still write while the buffer is queued and while the job sits in the ring, up to eight jobs deep: it is an MMAP buffer or a DMABUF another process may hold. Rewriting a size after QBUF let the engine read up to several GiB past the buffer's IOVA. Every context of both nodes shares the engine's DART, so that read could land in another context's buffers, such as another user's encode source frames, and decode them into the attacker's CAPTURE buffer, or fault on an unmapped IOVA and reset the engine under every other context's jobs. Give each slot of the job FIFO a driver-owned source copy. device_run copies the frame into the copy of the slot its job will take, parses that copy and points DD_INPUT at it; the engine never reads the OUTPUT buffer. Only device_run, which v4l2-m2m runs one at a time and only with room in the FIFO, fills a copy, and the engine is done with a slot's copy once its job is taken off the ring or the engine is reset. The copies are cached non-contiguous DMA allocations, so the parse runs on cached memory, with a quarter of headroom so a stream rarely reallocates them; they are freed when the engine runtime-suspends. At most APR_MAX_INFLIGHT copies exist per engine. The parse at QBUF stays, for the source-change check and to fail a malformed frame early; a frame changed after QBUF so that it no longer parses fails its own job. device_run also checks that the CAPTURE buffer is large enough for the current format. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
The decoder advertises V4L2_FMT_FLAG_DYN_RESOLUTION, but a frame of a new size queued while CAPTURE was set up raised SOURCE_CHANGE at QBUF time, before decode reached it, left the CAPTURE format at the old size while CAPTURE was busy, and never marked the last old-size CAPTURE buffer LAST. job_ready just stalled on the new frame. A client following the stateful decoder sequence (drain to LAST, STREAMOFF and G_FMT on CAPTURE) waited for a LAST that never came, or read the old format back. Handle a change where Documentation/userspace-api/media/v4l/dev-decoder.rst puts it, in device_run when decode reaches the frame: give back every earlier frame of the context, switch the OUTPUT and CAPTURE formats to the new geometry, queue SOURCE_CHANGE, and return the next CAPTURE buffer empty with LAST. The new frame stays first on OUTPUT and no job runs until CAPTURE is restarted or a START command resumes decoding; START now also clears vb2's LAST-dequeued state, so DQBUF works again after it. The formats change under hw_lock, which G_FMT and TRY_FMT take, as device_run does not hold vdev_lock. Before CAPTURE streams, the next frame to decode still sets the formats at QBUF, now including the CAPTURE format while CAPTURE buffers exist: device_run refuses a CAPTURE buffer smaller than the format needs. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
Kconfig and the decode descriptor comment still said decode exists only on T6000 and T8140, but every APR variant has had a decoder node since "media: apple: prores: give every APR engine a decoder node". The frame parser bounded the second field of an interlaced frame to 16384 slices and the first to 262144, with no reason given: both fields have the same geometry. Use one named bound for both. Interlaced frames are still refused before a descriptor is built, so nothing decodes differently. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
Fixes for #2620 (review) and the overlapping items of #2620 (comment), as four commits on top of 64b404a (no rewrite). Blocker 1, source-buffer TOCTOU (3e0c7ee): the engine no longer reads the OUTPUT buffer. Each slot of the job FIFO has a driver-owned copy (at most APR_MAX_INFLIGHT per engine, cached non-contiguous DMA memory, grown with a quarter of headroom, freed at runtime suspend). device_run copies the frame into the copy of the slot its job takes, parses the copy, and points DD_INPUT at it. A frame rewritten after QBUF either decodes as it was when copied or fails its own job; the engine only ever follows sizes checked on memory userspace cannot reach. I found no public input-length field in the decode descriptor, so a copy it is. The QBUF parse stays for the source-change decision and early failure. Blocker 2, hung ring (9c55a39): declaring the ring hung masks the engine interrupt; apr_take_done() takes nothing while it is hung; the watchdog skips it and resets a hung ring even when no job is left (no early return); device_run waits on hung || resetting. Runtime suspend (a power-off, so a reset) clears the flag. Blocker 3, mid-stream DRC (938b9ee): handled in device_run when decode reaches the new frame, per dev-decoder.rst: earlier frames go back first, formats switch (OUTPUT and CAPTURE) under hw_lock, SOURCE_CHANGE is queued, then the next CAPTURE buffer goes back empty with LAST. Nothing runs until CAPTURE STREAMOFF/STREAMON or DECODER_CMD START (which now also clears vb2's LAST-dequeued state). G_FMT after the event returns the new size. device_run refuses a CAPTURE buffer smaller than the current format. Cheap items from the MERGETRAIN review (0f162d2): Kconfig and the descriptor comment no longer say decode is T6000/T8140-only; one named slice bound for both fields (the 16384 had no reason). Not changed: an ERROR still fails every job in the ring at that moment (the status does not say which descriptor failed; documented in apr_take_done()); 4946927's noreply SoB would need a history rewrite. Testing
Still to run (hardware)Kit with both arms built for fleet79 (old = 64b404a, new = this head), the st1fix rows, OOB with the post-QBUF rewrite probe on, and a new
Assisted-by: LLM (Claude:Opus 5.5) |
…hange At a resolution change device_run switches the CAPTURE format before the client has seen SOURCE_CHANGE; the client is still dequeuing the last old-size frames and queues their buffers again. buf_prepare checked every CAPTURE buffer against the current format, so on a change to a larger size that QBUF failed with -EINVAL. dev-decoder.rst has the client queue those buffers as usual; one of them carries the change's LAST flag. On a Neo (T8140) a 1080p to 2160p and a 4:2:2 to 4:4:4 change failed this way; the downsizing changes passed only because the old buffers were large enough. Do not check a decoder's CAPTURE buffers against the current format at QBUF: queue_setup sized each for the format of its time. device_run gives back a buffer too small for the current format with ERROR and no payload, after the context's frames in the ring, and keeps the source frame queued for one that fits, instead of failing the frame. Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
Neo (J700, T8140) rows on 7.3.0-aurora-fleet81, and one more fix (cc64e59). Old arm 64b404a confirms blocker 1 on hardware: the post-QBUF rewrite probe (picture size flipped from a thread) gave a job timeout and repeated DART translation faults (reads far past the buffer) for about 40 s, then the machine reset. 0f162d2: SHA 6/6 match the reference, MIXED / DRAIN 6/6 / KILL x20 / TWO all as before, OOB 60/60 including every post-QBUF rewrite probe, 0 bad dmesg lines, no reset. DRC passed 3/5 (2160p to 1080p with START and with STREAMOFF, 4444 to 422). It failed both changes to a larger format (1080p to 2160p, 422 to 4444 at 1080p): a CAPTURE QBUF of an old buffer returned EINVAL while the last old frames were still draining. Fix, cc64e59: device_run switches the CAPTURE format before the client sees SOURCE_CHANGE, and buf_prepare then checked the old buffers against the new, larger format. The decoder's CAPTURE buffers are no longer checked at QBUF; queue_setup sized them for their format. device_run gives back a buffer too small for the current format with ERROR and no payload, after the context's frames in the ring, and keeps the source frame queued. Testing
Assisted-by: LLM (Claude:Opus 5.5) |
|
Neo (J700, T8140, ProRes id 0x40010) row at cc64e59, fleet81 kernel, this driver swapped in at runtime, default command line:
The two upsizing DRC cases that failed at 0f162d2 pass now. For comparison, the same TOCTOU flip case on 64b404a produced repeating DART translation faults and reset the Neo. FPS, same Neo and kernel, interleaved N=3 medians, 64b404a vs 0f162d2 (the driver-owned source copy; cc64e59 doesn't touch this path):
The copy costs nothing measurable here, including the 2160p 4444 worst case. Still to run: the same rows on M1 Pro, J616s, a T6050 and J815. Assisted-by: LLM (Claude:Opus 5.5) |
Problem
The ProRes decode stack is three stacked PRs: #2396 (decoder node on every APR engine, input bounds, DYN_RESOLUTION), #2462 (parse each source frame once) and #2491 (several decode jobs in the ring, retire on the engine's finished-job id). #2396 no longer merges into integration/aurora since #1881 (T8142 ProRes) landed, and #2491's head doesn't carry #2396's last commit (d409342, DYN_RESOLUTION).
Change
This branch is #2491's head a1ad1a8 with two merges on top, so every reviewed commit keeps its SHA:
Kconfig: media: apple: prores: T8142 (M5) ProRes encoder #1881's SoC list (adds M5/T8142 and theprores-<soc>-init.binwording) with this stack's "codec engine" and decode sentence.apple-prores-drv.c: media: apple: prores: T8142 (M5) ProRes encoder #1881's newapr_t8142variant and this stack'sstruct apr_bufwere added at the same spot; both are kept.apr_t8142usesAPR_DESC_BYTES, which the stack keeps as an alias ofAPR_ENCODE_DESC_BYTES, so its encode descriptor size doesn't change and it gets the decoder node like every other variant.The merge applies exactly #1881's prores lines onto the stack: the sorted +/- lines of
git diff <merge-base> integration -- drivers/media/platform/apple/proresand ofgit diff 64b404a4^1 64b404a4 -- drivers/media/platform/apple/proresare identical.Testing
W=1build ofdrivers/media/platform/apple/prores/at 64b404a: no warnings.Still to run
Supersedes #2396, #2462 and #2491 (closed with links here).
Assisted-by: LLM (Claude:Opus 5.5)