Skip to content

media: apple: prores: add disabled T8112 variant - #1295

Draft
RyanTheTide wants to merge 6 commits into
integration/aurorafrom
prores/t8112
Draft

RyanTheTide wants to merge 6 commits into
integration/aurorafrom
prores/t8112

Conversation

@RyanTheTide

@RyanTheTide RyanTheTide commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add the fixed 64-record T8112 core initialization as clean-room per-SoC driver constants
  • select encode-v1, shared decode-v0, the newer statistics registers, two 16 KiB resources, and no wrapper table
  • validate both IRQ resources while requesting frame completion only on the primary IRQ
  • document apple,t8112-prores and add disabled APR/DART nodes for T8112

Dependencies

Scope classification

The retained clean reduction shows one table selected by SoC 0x8112/variant zero with no board, serial, calibration, or per-unit input. It is fixed hardware initialization, not installer-extracted tuning. There is no T8112 APRI v2 or request_firmware path, and no installer change.

Verification

  • git diff --check: pass
  • checkpatch --strict on the logical binding, driver, and DTS patches: pass, 0 errors and 0 warnings
  • clean-room transcription: 64 ordered, unique, aligned records; masks contain all values
  • buildbox h-51198: arm64 W=1 ProRes objects and QEMU KUnit passed, 20/20 subtests
  • buildbox h-51199: full arm64 W=1 Image/modules and DTBs built; Image sha256 bd7f2acf72f77dcafbfbf9d387d889defa65eeeffc26bd7afd10cf2b6134f575
  • buildbox h-51221: dt_binding_check and ProRes-scoped CHECK_DTBS passed for J413, J415, J473 and J493

The earlier build-volume STOP refusals, missing base-image dtschema tool, legacy APR override, and over-broad adjacent-DART deletion were preserved in the task report before the final green retries.

Hardware

Hardware-gated. Both APR consumer nodes remain disabled; no board enables or PMP report changes are included.

Assisted-by: LLM (Claude:Opus 5.5)

Add a compatible-gated stateful decoder alongside the existing encoder.

Validate complete ProRes frames and pack the 0x100-byte non-RAW descriptor.

Share the APR ring with generation-aware variable-size accounting.

Snapshot completion diagnostics before the W1C/tail handoff.

Preserve reset-based timeout recovery.

Cover descriptor layout, parser bounds, and mixed ring wrap with KUnit.

Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Assisted-by: LLM
Document the single-compatible T8112 engine shape: two register windows,
two interrupts, one IOMMU, and the core/performance power domains.

The nodes remain disabled.

Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Add the fixed 64-record core initialization selected solely by T8112.
Use encode-v1, shared decode-v0, the newer statistics registers, and no
wrapper table or firmware dependency.

Request only the primary completion interrupt; retain the second resource
for a future qualified bandwidth-request handler. Cover the compatible's
variant contract with KUnit.
Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Add the disabled APR DART and codec nodes using the two 16 KiB register
windows and two level-high interrupt resources described by the T8112
hardware contract.

Keep the performance provider and both new consumers disabled.
Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
@RyanTheTide RyanTheTide added the hardware-gated Requires approved hardware validation before merge label Nov 9, 2026
Override the older generated APR properties after their include and remove the unused adjacent DART range, leaving the final disabled node with the qualified single-IOMMU and two-domain contract.

Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Keep the adjacent disabled DART node because the separate SCDC coprocessor references it. APR still maps only its qualified primary DART.

Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Early note on this draft (no full review yet):

  1. drivers/media/platform/apple/prores/apple-prores-drv.c:251-320 (apr_t8112_engine_tunables, selected through apr_t8112 at :380-388): a 64-entry register init table hardcoded for one SoC. Values like these belong to the machine. Have the boot loader pass them from the device's own tree as a DT property on the APR node, have the driver read them from there, and remove the table from the source. Until that property exists, the block stays disabled, as the DT already does.

Assisted-by: LLM (Claude:Opus 5.5)

@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Closing: the T8112 engine init table is hardcoded in the driver; a rewrite should load it like the other engines and build on #2620's decoder.

@RyanTheTide RyanTheTide reopened this Nov 22, 2026
@RyanTheTide

Copy link
Copy Markdown
Contributor Author

Reopened and kept as a draft; the comment above lists what it still needs before review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hardware-gated Requires approved hardware validation before merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant