Repository navigation
media: apple: prores: add disabled T8112 variant - #1295
Draft
RyanTheTide wants to merge 6 commits into
Draft
RyanTheTide wants to merge 6 commits into
RyanTheTide wants to merge 6 commits into
Conversation
Add a compatible-gated stateful decoder alongside the existing encoder. Validate complete ProRes frames and pack the 0x100-byte non-RAW descriptor. Share the APR ring with generation-aware variable-size accounting. Snapshot completion diagnostics before the W1C/tail handoff. Preserve reset-based timeout recovery. Cover descriptor layout, parser bounds, and mixed ring wrap with KUnit. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com> Assisted-by: LLM
Document the single-compatible T8112 engine shape: two register windows, two interrupts, one IOMMU, and the core/performance power domains. The nodes remain disabled. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Add the fixed 64-record core initialization selected solely by T8112. Use encode-v1, shared decode-v0, the newer statistics registers, and no wrapper table or firmware dependency. Request only the primary completion interrupt; retain the second resource for a future qualified bandwidth-request handler. Cover the compatible's variant contract with KUnit. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Add the disabled APR DART and codec nodes using the two 16 KiB register windows and two level-high interrupt resources described by the T8112 hardware contract. Keep the performance provider and both new consumers disabled. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Override the older generated APR properties after their include and remove the unused adjacent DART range, leaving the final disabled node with the qualified single-IOMMU and two-domain contract. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Keep the adjacent disabled DART node because the separate SCDC coprocessor references it. APR still maps only its qualified primary DART. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com>
Contributor
Author
|
Early note on this draft (no full review yet):
Assisted-by: LLM (Claude:Opus 5.5) |
Contributor
Author
|
Closing: the T8112 engine init table is hardcoded in the driver; a rewrite should load it like the other engines and build on #2620's decoder. |
Contributor
Author
|
Reopened and kept as a draft; the comment above lists what it still needs before review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Scope classification
The retained clean reduction shows one table selected by SoC 0x8112/variant zero with no board, serial, calibration, or per-unit input. It is fixed hardware initialization, not installer-extracted tuning. There is no T8112 APRI v2 or request_firmware path, and no installer change.
Verification
The earlier build-volume STOP refusals, missing base-image dtschema tool, legacy APR override, and over-broad adjacent-DART deletion were preserved in the task report before the final green retries.
Hardware
Hardware-gated. Both APR consumer nodes remain disabled; no board enables or PMP report changes are included.
Assisted-by: LLM (Claude:Opus 5.5)