Repository navigation
media: apple: add ProRes decode-v0 node - #1259
Closed
RyanTheTide wants to merge 1 commit into
Closed
RyanTheTide wants to merge 1 commit into
RyanTheTide wants to merge 1 commit into
Conversation
Add a compatible-gated stateful decoder alongside the existing encoder. Validate complete ProRes frames and pack the 0x100-byte non-RAW descriptor. Share the APR ring with generation-aware variable-size accounting. Snapshot completion diagnostics before the W1C/tail handoff. Preserve reset-based timeout recovery. Cover descriptor layout, parser bounds, and mixed ring wrap with KUnit. Signed-off-by: Ryan Murray <81541646+RyanTheTide@users.noreply.github.com> Assisted-by: LLM
Contributor
Author
|
Blockers: 1.
If any piece is not in #2620 and is still wanted, carry it there as its own commit with a hardware row, rather than rebasing this branch. Candidates are the 0x100/0x180 mixed-entry ring accounting test, and snapshotting status/detail before the W1C. HW row: none for this PR (close). For #2620: Neo J700 and M1 Pro progressive Assisted-by: LLM (Claude:Opus 5.5) |
Contributor
Author
|
Superseded by #2620, which brings hardware ProRes decode to every APR engine with hardware rows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compatibles while leaving the encoder queues and controls unchanged
descriptor with linear NV16, NV24, P216, and P416 capture layouts
the shared APR ring, including generation-bit wrap and split ring copies
existing reset-before-release timeout rule, and mark cancelled jobs without
inventing a hardware cancellation opcode
profile families, and variable-size ring accounting
Tests
Testing complete. Ran 15 tests: passed: 15Current limitation
The parser validates progressive and two-picture interlaced frames, but the
submission path currently returns
EOPNOTSUPPfor the latter. The cleandecode-v0 contract establishes host repacking and one-picture submissions but
does not establish the second field's descriptor geometry. This draft does
not guess a field index or output offset that could corrupt a capture surface.
Guarded hardware qualification plan
No target hardware was used for this change.
On Neo/T8140, first run a generated progressive
apcnframe into P216 withthe validated frame end at an IOMMU guard page, 64-byte rows, 128-byte plane
placement, poisoned padding, and guards after both output regions. Require a
DONE-only IRQ, a tail advance of 0x100, no DART fault, and a visible-sample
comparison against a software decode. Repeat with an alpha-bearing
ap4hframe into color-only P416 to prove 4:4:4 layout and alpha discard. Capture
all status/detail words and test real reset recovery before enabling wider
qualification.
On M1 Pro/T6000, repeat the same
apcnandap4hcomparisons while checkingthe a0 initialization/statistics registers and the T6000 DVA window. Keep the
macOS volume and xART ledger read-only. Interlaced qualification starts only
after a clean contract addition defines field-index geometry; it will use two
bounded one-picture submissions and compare both field parities.
Assisted-by: LLM (Claude:Opus 5.5)