Repository navigation
Conversation
8978db3 to
475d43b
Compare
The T8142 and T6050 configurations boot the AOP through a second mailbox, named "setup", as well as the RTKit one. Take that boot only when the device tree gives the AOP a mailbox of that name. A device tree that lists only "mbox" gets the boot without the setup port, which is the one the AOP takes where no setup mailbox is described. Signed-off-by: Satya Benson <satya@benson.earth>
475d43b to
f252206
Compare
|
The code change is clean: every use of the configuration's My concern is what the property ends up meaning. The J775c's AOP does have the setup mailbox (#2542 described it, and with it the setup-port boot timed out with "AP power on: false, endpoints: 0/0"), so on that board the J775c DT leaves out a mailbox that exists in order to pick the other boot. That makes Assisted-by: LLM (Claude:Opus 5.5) |
Describe when the setup mailbox must be listed and what its omission means for the firmware boot protocol. Signed-off-by: Satya Benson <satya@benson.earth>
|
Codex GPT-6.2 Sol on @satchlj's behalf. I checked the AOP probe and boot data handling, the RTKit HELLO decoder, and the history in #2542. HELLO exposes a version range, and #2542 reports protocol version 12 on both boot paths. The setup mailbox is also opened before the CPU starts, so the current handshake supplies no way to choose it at that point. The binding now says to list |
|
Re-review of e157d43: Blockers: 1. Earlier point:
Nit: the new binding text (apple,t8152-aop.yaml:46) says that listing HW row: J775c at e157d43 with the Assisted-by: LLM (Claude:Opus 5.5) |
e157d43 to
e9fe5bb
Compare
|
Checked e9fe5bb: the Assisted-by: LLM (Claude:Opus 5.5) |
e9fe5bb to
23f33fc
Compare
|
Checked 23f33fc: both commits now carry your Assisted-by: LLM (Claude:Opus 5.5) |
DjDeveloperr
left a comment
There was a problem hiding this comment.
Pre-PR checklist review at 23f33fc765c0: 0 code/policy/attribution/naming/CI blockers; holding only for §5 hardware evidence on the live head.
Code, Binding, Attribution, and CI Audit (§1–§4, §6)
- Code (§1–§3): Clean. Checked every
cfg.setup_portsite indrivers/soc/apple/aop.rs— all three (AopData::new,setup_open, and the boot branch inprobe()) now go through the per-devicesetup_portflag derived fromcfg.setup_portand DTmbox-namescontaining"setup". All downstream paths (SetupPortCallback,source_ring(),remove(),start(),sleep_enter(),sleep_undo()) handlesetup_queue == Nonesafely. - In-tree DTs: Verified
t8140.dtsi,t8142-j813-audio.dtsi, andt6050-die0.dtsiall list"setup"inmbox-names, so existing machines retain unchanged behavior. - Attribution (§4): Both commits (
f34b611b138d,23f33fc765c0) carry human author/committer identity andSigned-off-by: Satya Benson <satya@benson.earth>only, with zero AI trailers in commits. - CI: All 8 checks (
dt-checks,host-tests,source,rust-build,kunit, and all threeDWC3/ATCmatrix jobs) are green.
Non-blocking Nit
Documentation/devicetree/bindings/soc/apple/apple,t8152-aop.yaml:46-48states that includingsetupselects the setup-port boot, whereasHW_CFG_T8152(drivers/soc/apple/aop.rs:3146) setssetup_port: false, so a plainapple,t8152-aopDT listingsetupwould have it silently ignored. Noting that in the binding or warning at probe whensetupis listed with!cfg.setup_portwould tighten that up.
Holding for §5 Hardware Evidence on 23f33fc765c0
- J775c (
mbox-only DT) booted on23f33fc765c0(the earliercand-7run was on an older base + 84 unrelated commits, and23f33fc765c0is noted untested): AOP RTKit up, not indevices_deferred, no AOP errors. - At least one Mac with a
setupmailbox (T8140, T8142, or T6050) booted on23f33fc765c0confirming the setup-port boot path still completes cleanly. - Regression row for the run:
0 SELinux denials, 0 failed units, 0 new kernel errors.
Assisted-by: LLM (Gemini 4 Neon)
|
J775D (M5 Ultra Mac Studio, T6050) row: the same result as the J775c.
We'll send the J775D tree change as its own PR on top of this one. Assisted-by: LLM (Claude:Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf.
soc: apple: aop: take the setup-port boot only when the device tree gives the AOP a mailbox namedsetup. The T8140, T8142 and T6050 configurations open that second mailbox. A device tree whose AOP lists onlymboxnow gets the boot without the setup port.Selection: the AOP node's
mbox-namesproperty, not the SoC or the board. The configuration'ssetup_portstill has to be true, and the property is the only other input.Effect on the tip's device trees: every tip DT whose AOP uses one of those configurations describes a
setupmailbox:t8140.dtsi;t8142-j813-audio.dtsi;t6050-die0.dtsi.For them nothing changes. The only DT that takes the other path is one that lists
mboxalone, such as #2102's J775c board file.Base:
integration/auroraf0c51766e9c5(rebased 2026-11-20 14:4xZ; #2088, #2101 and #2447 sincec92ed8517b79touch none of this PR's files).Testing
J775c (Mac Studio, M5 Max, T6050), on lobata.
Kernel: cand-7,
324280cadc47=integration/aurorad91db387c720+ 85 commits.d91db387c720is now several merges behind this PR's base (#1568, #1889, #1534, #1881, #1899, #2011, #1956, #1957); none of them touchaop.rs. Booted 2026-11-20 12:12Z. A run on cand-8, built on this base, will follow.mbox-names = "mbox"and no setup mailbox.aop.rs(git log d91db387c720..324280cadc47 -- drivers/soc/apple/aop.rs).mboxonlyapple_aop 290c00000.aop: RTKit: Initializing (protocol version 12); driver bound; not indevices_deferred; no AOP error line (all from one boot)7400d465c320, the tip's code without this PRmboxonlyd2f8af83bf98, without this PRsetup port: boot incomplete (AP power on: false, endpoints: 0/0): ETIMEDOUT(-110)On cand-7, macaudio also probes and prints
driver can't assure safety on this model, disabling speakers. On cand-4 it was deferred on its CPU DAI. My inference is that the AOP came up far enough to register its audio DAI, but I haven't checked the AOP's endpoint list.Untested:
setupmailbox (T8140, T8142, other T6050 boards), where the code path is unchanged;Assisted-by: LLM (Codex:GPT-6.2)