Repository navigation
Conversation
… sleep On J775c, a suspend-to-idle that powers the four ATC USB domains off does not come back: resume hangs in the noirq power-on of the USB-C domains (the dwc3 USB, ACIO and ATC PHY domains), with an RCU stall and no wake source involved (pm_test=platform). With these domains kept on, pm_test=platform resumes and three real suspend-to-idle cycles complete, each woken by the RTC alarm. lobata's working J775c kernel keeps the same four domains on for system sleep. Keeping them on also keeps their AON and common parents, which the wake path needs, powered. Signed-off-by: Satya Benson <satya@benson.earth>
|
Claude Opus 5.5 on @satchlj's behalf: J775c idle-power regression check with this change: not worse than the default.
So holding the four ATC USB domains on costs nothing measurable against the default here. This is only the "nothing worse" check; I haven't measured the domains held on vs off on the same kernel. 🤖 Generated with Claude Code |
|
The change is safe at runtime today: on T6050 dwc3-apple doesn't runtime-suspend ( One design question: what this needs is "not powered off during system sleep", which is what It would also be good to see one s2idle run on J775c with a USB device in use across the sleep (a mounted drive read before and after), since that is listed as untested. Assisted-by: LLM (Claude:Opus 5.5) |
|
Claude Opus 5.5 on @satchlj's behalf On RyanTheTide's question (
So on J775c, keeping Real RTC row, same stack, Before I switch this PR to
All rows above used a diagnostic serial-console cmdline; the validation rows will use the default one. Separately, the PHY firmware stop returns |
437d9e8 to
a142752
Compare
|
J714s (Apple M5 Pro / T6050) combined-stack
Assisted-by: LLM (Gemini 4 Neon) |
a142752 to
5ee36b9
Compare
|
Claude Opus 5.5 on @satchlj's behalf Closing in favour of #2664 (#2664). Why. On J775c the failure this PR addressed is not a missing DT policy:
#2664 holds the PHY's active domains out of genpd during suspend-to-idle, on every T6050 combo PHY, with no DT property and no board list. Rows. Stock J775c DTB, with none of this PR's properties:
Thanks @RyanTheTide for the Evidence size. One boot per row. Without #2664 the fault reproduced on both bases:
With #2664: 3/3 platform and 3/3 real RTC cycles on each base, one boot per row. The tip rows carry the helper's |
Claude Opus 5.5 on @satchlj's behalf.
arm64: dts: apple: t6050: give the four ATC USB power domains (ps_atc0..3_usb, and die 1's ATC1 on the Ultra)apple,always-on, so system sleep doesn't power them off. That also keeps their AON and common parents on. The tip already keeps theatcN_usb_aondomains on, because "the ATC PHY loses its state without it".Selector: the SoC DT (
t6050-peripherals.dtsi,t6050-dieX.dtsi,t6050-die0.dtsi). Every T6050 board gets it, and no driver code changes.Base:
integration/auroradf62a8c4d38d.Why
On J775c, a suspend-to-idle that powers these domains off never comes back. With #2488's head and #2557, the host's D0 check now passes. Resume then hung in the noirq phase, with no wake source involved (
pm_test=platform). Ftrace probes in the stall dump showedgenpd_resume_noirqentered and never returned for:38a280000.usb;2a3000000.phydomains.lobata's working J775c kernel keeps these same four domains on for system sleep (
e1c71b143557there). That kernel passes real s2idle cycles. Its comment gives the reason as the USB DARTs having no power-down path in the T8110 backend. I haven't checked that against today'sapple-dart.c, which has more suspend handling, so this PR states only what's observed.Testing (J775c, lobata)
Kernel: cand-10,
6ebd4f505fd5=integration/auroradf62a8c4d38d(this PR's base) + 84. It carries #2488's head, #2557, #2556 and #2565. The J775c DT is #2102's board file, withapple,always-onadded toatc0-usb,atc1_usb,atc2_usbandatc3_usb, the same change as this PR. The command line addsno_console_suspend initcall_debug. Entered by an ordinary reboot as a one-shot.pm_test=platformPM: suspend entry (s2idle)…apple_pcie_suspend_noirq returned 0…suspend debug: Waiting for 5 second(s)…PM: suspend exit, rc 0, withpm_async=0. Everygenpd_resume_noirqreturns, including the ACIO, ATC PHY and USB domains.rtcwake -d rtc0 -m freeze -s 30, ×3,pm_async=1/sys/power/pm_wakeup_irq= 151 (macsmc-rtcthroughapple_spmi), RTC IRQ count 0→1→2→3. No D0 refusals.Static checks:
CHECK_DTBSreports no warnings for every T6050 board (j714c, j714s, j716c, j716s, j775c, j775d, j873s, k114c). J775c's DTB hasapple,always-onon its 4 ATC USB domains, and J775d's on 5 (atc0–atc3, plus die 1'satc5_usb).Idle (regression check, the only idle measurement): 7.935 W on the same cand-10 boot, against 8.582 W on lobata's default (Shelly, 20 steps; details in the comment below). This doesn't measure held-on against powered-off on the same kernel.
Untested:
🤖 Generated with Claude Code