Repository navigation
Conversation
On T6050, apple-aop opens the AOP's setup port by name ("setup"), as
t6050-die0.dtsi describes for the laptops. The J775c file gave the AOP
only its ASC mailbox, so the probe fails with -ENODATA and J775c gets no
AOP services, its audio included.
The file already had the mailbox, but as mailbox@4d067c000, an
"apple,t6050-secure-mailbox" that nothing referenced. The ADT has it
at 0x2d067c000 (aop-exclave-mailbox, size 0x4000, interrupts 0x249 and
0x246), where t6050-peripherals.dtsi puts aop_setup_mbox. Describe it
as that dtsi does, on dart-aop stream 1, and add it to the AOP's
mboxes.
Signed-off-by: Satya Benson <satya@benson.earth>
|
Claude Opus 5.5 on @satchlj's behalf: J775c row on this head: the DT part works, and the probe now fails one step later. It times out on the setup port instead of failing the lookup. Kernel: lobata's cand-5, Aura's T6050 handoff now accepts stream 1 and enables the mailbox: Kernel:
So nothing answers on the setup port: 0 endpoints, no AP power ack. Facts that may matter (J775c ADT, interfacing data): the node is Status: this PR is correct as a description of the hardware, but on its own it does not make J775c's AOP probe. Options I see:
I'll keep this PR open until that is settled, and won't claim a working AOP from it. 🤖 Generated with Claude Code |
|
Claude Opus 5.5 on @satchlj's behalf: a same-method comparison of the AOP's probe path. It changes my reading above: the AOP's firmware most likely never started, rather than a silent setup port. Correction: "the setup port is exclave-assigned on the desktop" is a hypothesis, not something I've shown.
The timeout comes about 2 ms after RTKit starts, so the driver isn't waiting on a mailbox that never answers. So on J775c the working path is the T8152-style boot, and this PR makes the tip's driver take the T6050 setup-port path instead. I won't propose this PR for merging as it stands. The description is right for the hardware, but the probe that works is the one without it. A choice for whoever owns
Neither is tested. (a) is a one-line gate; (b) needs to know what the laptops' AOP state is at probe. 🤖 Generated with Claude Code |
|
Claude Opus 5.5 on @satchlj's behalf: J775c row: the AOP comes up without this PR's setup mailbox, once the driver gates the setup-port boot on
On cand-7, macaudio also probes and logs So on J775c this PR's setup mailbox makes the AOP worse than describing none. I'm leaving it open but not proposing it for merge. Unless someone finds a J775c use for the setup port, I'd close it in favour of #2556. AOP services past RTKit start, and AOP sleep and wake, are untested on either kernel. 🤖 Generated with Claude Code |
|
Superseded. The 11-20 J775c row above shows the AOP comes up without this setup mailbox once the driver takes the setup-port boot only when Assisted-by: LLM (Claude:Opus 5.5) |
73097b0 to
1bc4cca
Compare
DjDeveloperr
left a comment
There was a problem hiding this comment.
Adversarial pre-PR checklist review (§1–§6) on 1bc4ccab509a76b6fede555ca6cbe5176341332b.
Blockers (§2 / §5 — breaks J775c AOP probe, superseded by #2556):
- Regresses AOP bring-up on J775c (
arch/arm64/boot/dts/apple/t6050-j775c.dts:3122-3123): Your own J775c boot (cand-5,d2f8af83bf98) on this change showedapple_aopfailing probe with-110(ETIMEDOUT) on the setup port (setup port: boot incomplete (AP power on: false, endpoints: 0/0): ETIMEDOUT), leaving AOP services absent andmacaudiodeferred. Wiringmboxes = <&aop_mbox>, <&aop_setup_mbox>;andmbox-names = "mbox", "setup";intoaop@290c00000forces the setup-port boot path that fails on J775c. - Superseded by #2556 while still open as non-draft: Your
cand-7(324280cadc47) boot proved that keepingmbox-names = "mbox"without this PR, paired with #2556 (soc: apple: aop: take the setup-port boot only with a "setup" mailbox), bringsapple_aopup cleanly on J775c (RTKit: Initializing (protocol version 12), bound, nothing deferred). Once #2556 lands, merging this PR as-is would actively re-break J775c. - CI / PR state: No
dt-checksCI has run on this PR (base is draft #2102'sfeat/j775c-rebased-20261116), and the PR body still describes the change as untested rather than superseded/failing.
Checks passing:
- §4 Clean-room & attribution: Commit
1bc4ccab509acarries human author/committer and humanSigned-off-byonly (0 AI trailers); PR body includesAssisted-by:; values are ADT interfacing data. - §1 / §3 / §6: No model gating, hardcoded safety values, or naming issues.
Requested action: Close this PR in favor of #2556. If you still want to fix or drop the unreferenced mailbox@4d067c000 node in #2102, remove the aop mboxes/mbox-names = "mbox", "setup" wiring, convert/rebase as needed, re-verify on J775c, and ensure dt-checks runs cleanly.
Assisted-by: LLM (Gemini 4 Neon)
|
Claude Opus 5.5 on @satchlj's behalf. Closing as superseded by #2556, per @DjDeveloperr's review.
J775c's AOP needs #2556 and no setup mailbox in the DT, so merging this after #2556 would break J775c again. Assisted-by: LLM (Anthropic:Claude Opus 5.5) |
Claude Opus 5.5 on @satchlj's behalf.
Stacked on #2102 (the J775c device tree); review the last commit.
arm64: dts: apple: t6050-j775c: give the AOP its setup mailbox.Problem. On lobata's cand-4 (
integration/aurorae0ee46a1+ 80 commits, including #2102's J775c DT),apple_aop 290c00000.aop: probe with driver apple_aop failed with error -61, at boot and again on a manual bind. Without the AOP there are no AOP services and no J775c sound card.aop.rsmatchesapple,t6050-aopwithHW_CFG_T6050, which opens a mailbox namedsetup.mbox-names = "mbox"only.available.Change.
mailbox@4d067c000(apple,t6050-secure-mailbox), and nothing referenced it.aop-exclave-mailbox, size 0x4000, interrupts 0x249 and 0x246). That is wheret6050-peripherals.dtsiputsaop_setup_mboxfor the laptops.mboxes = <&aop_mbox>, <&aop_setup_mbox>; mbox-names = "mbox", "setup";.iommus = <&aop_dart 1>adds dart-aop stream 1, so Aura's handoff also checks that stream's locked table.All values are from J775c's ADT or the tip's T6050 DT (interfacing data).
Testing
dtccompiles the file. The AOP'smboxesholds two phandles, the second beingmailbox@2d067c000, and the4d067c000node is gone.apple_aopbinding and Aura's handoff accepting stream 1. That boot is lobata's next candidate, and I'll post the kernel identity and the result here.Assisted-by: LLM (Anthropic:Claude Opus 5.5)