Repository navigation
iio: aop_las: stop the lid angle reports for system sleep - #2223
Merged
DjDeveloperr merged 1 commit intoNov 19, 2026
Merged
DjDeveloperr merged 1 commit into
DjDeveloperr merged 1 commit into
Conversation
The firmware streams the lid angle at its own interval whether anyone reads it or not, and the AOP mailbox interrupt stays enabled in suspend- to-idle, so every report ends the CPUs' idle period. On the J815 (MacBook Air 15-inch, M5), a 4 h lid-closed s2idle left the freeze loop 14478 times, once every 0.999 s, matched by 14413 AOP mailbox interrupts and 14551 RTKit receive works. The device-motion service already stops its reports for sleep, and the light sensor's equivalent is aurora-silicon#1876; the lid angle is the AOP stream left running. Read the interval the firmware runs at when the system sleeps, set it to 0, and write it back when the system wakes, from a PM notifier as aop_devmotion does. A service that refuses the read is left alone. Lid open and close reach the kernel from the SMC, not from this sensor, so a sleeping system still wakes on the lid. Assisted-by: Claude Opus 5.5 Signed-off-by: Nick <nekreshen@yandex.ru>
DjDeveloperr
merged commit Nov 19, 2026
3655f51
into
aurora-silicon:integration/aurora
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The AOP firmware streams the lid angle at its own interval whether anyone reads it or not. The AOP mailbox interrupt stays enabled in suspend-to-idle, so every report ends the CPUs' idle period.
On the J815 (MacBook Air 15" M5), a 4 h lid-closed s2idle left the freeze loop 14478 times, once every 0.999 s:
The device-motion service already stops its reports for sleep, and the light sensor's equivalent is #1876. The lid angle is the AOP stream left running.
Change: a PM notifier, as
aop_devmotionhas:A service that refuses the read is left alone. Lid open and close reach the kernel from the SMC, not from this sensor, so a sleeping system still wakes on the lid.
Tested on J815 in the deep-sleep builds since 2026-11-15: the lid-angle reports stop at the sleep and come back at the wake, and the lid still wakes the machine.
checkpatch --strictand rustfmt clean.W=1onintegration/aurora0abc2f3.Part of the J815 bring-up; board results are summarised in discussion #135.
🤖 Generated with Claude Code