Repository navigation
soc: apple: rtkit: don't warn twice about a crash on the crashlog endpoint - #2496
Merged
DjDeveloperr merged 1 commit intoNov 20, 2026
Merged
Conversation
…point
The AOP leaves the crashlog endpoint out of its endpoint map, so it is
never started ("crashlog endpoint not in the endpoint map" at every
boot). When the AOP firmware crashes it still reports on that endpoint,
and the receive path first warns
RTKit: Message to undiscovered endpoint 0x01
before apple_rtkit_crashlog_rx() reports the crash itself. The warning
says "to", but it is a message from the co-processor, and read next to a
sleep commit it looks like the AP sent something to an endpoint it never
discovered. On the J700 it led to exactly that misreading of an
intermittent AOP crash during deep sleep.
Leave the crashlog endpoint out of that warning, as its own handler
names every message there, and say "from" for the endpoints that remain.
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
DjDeveloperr
approved these changes
Nov 20, 2026
DjDeveloperr
left a comment
Contributor
There was a problem hiding this comment.
Looks right. The crashlog endpoint still goes through apple_rtkit_crashlog_rx(), which already reports the crash for firmware that leaves the endpoint out of its map, so dropping the second warning loses nothing, and "from" is the accurate wording for the remaining case. CI 7/7 on this head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. The AOP leaves the RTKit crashlog endpoint (0x01) out of its endpoint map, so it is never started. When the AOP firmware crashes it still reports on that endpoint, and the receive path first warns
RTKit: Message to undiscovered endpoint 0x01, thenapple_rtkit_crashlog_rx()reports the crash. The warning says "to" for a message from the co-processor. On the J700 (Neo) this line was read as the AP sending to an endpoint before it was discovered across sleep, when it is the AOP's own crash report.Change. The generic undiscovered-endpoint warning now skips the crashlog endpoint, because
apple_rtkit_crashlog_rx()prints a line for every message there ("co-processor has crashed: ...", "crashed without a usable crashlog buffer" or "Unknown crashlog message"). For the other endpoints it now says "from". The log changes; nothing else does.Testing. Builds clean with
W=1(drivers/soc/apple/rtkit.o, fleet arm64 config, LLVM). checkpatch is clean. No tool in the tree greps for the old string.Still to run. This can't be checked on hardware on demand: the AOP crash is intermittent (0 of 17 boots / 51 deep sleeps on the Neo in a dedicated repro run).
Context: the J700 AOP crash this came from
apple-sleep: 10 coprocessors up and stopped->apple_aop: RTKit: Message to undiscovered endpoint 0x01->co-processor has crashed: crash log buffer at 0x10040054000 not mapped (-2)->AOP firmware crashed. Later sleeps printfirmware crashed: sleeping without it.Assisted-by: LLM (Claude:Opus 5.5)