Repository navigation
arm64: dts: apple: t8142: share the AOP, ambient light and lid angle with every M5 - #2329
RyanTheTide wants to merge 2 commits into
Conversation
The AOP core, its mailboxes and dart-aop were described in the J813/J815
sound file (t8142-j813-audio.dtsi) and the ambient light and lid angle
services in each board file, so the MacBook Pro J704 had none of them.
The J704, J813 and J815 ADTs agree on /arm-io/aop (reg, interrupts
490-493, iop,ascwrap-v6), aop-exclave-mailbox (0x3d067c000, interrupts
497/494), dart-aop (0x390fc0000, interrupt 528) and every
/arm-io/aop/iop-aop-nub service, als included, and all three carry the
lid angle sensor's i2c1 "mogul-las" authentication chip.
Move aop_mbox, aop_setup_mbox, the aop node and its als and las
services to t8142-peripherals.dtsi and enable aop_dart in t8142.dtsi,
so every T8142 board gets them. The AOP core runs without its audio
child (J815 runs so today), and aop registers a service child only when
its firmware announces the service. t8142-j813-audio.dtsi keeps only
&aop { aop_audio }. dart-aop and aop have no ADT power-gates: AOP_DART
sits in the AOP's own always-on power tree, so the DART names no power
domain (the AOP DARTs are exempt from the DART power-domain rule).
J813 and J815 compile to the same tree apart from node order, phandle
numbers and aop_dart losing its now redundant status = "okay". J704
gains the AOP, both mailboxes, dart-aop, als and las.
The moved nodes are Thomas Glanzmann's (AOP, mailboxes, dart-aop:
"t8142-j813: Sound through the AOP"), Diljit Singh's and Nick's (als),
and Nick's (las).
Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
J813 row. The kernel is #2325's head with #1899/#1900 and
Not run: the covered/lamp ALS comparison and the lid at 30/90/120 degrees. The first needs the calibration file, and both need someone at the machine. |
|
J704 (MacBook Pro 14" M5), macOS 27.0 stub (26A428). Kernel: our J704 7.3.0 (integration/aurora be8d4cd + J704 GPU/DCP commits) on the installed Aurora Fedora, IIO_AOP_SENSOR_ALS/LAS=m. DTB: our J704 tree with this PR's J704 delta applied (aop_dart enabled; aop_mbox, aop_setup_mbox, aop with als/las), checked property by property against this branch's J704 tree.
|
|
Thanks @sithglan and @term-guy.
|
|
J815 (MacBook Air 15" M5) row: ALS and lid angle unchanged. Kernel: integration/aurora
Probes and log lines match the boots without this PR. |
Conflict: t8142-j815.dts (kept integration's J815 audio nodes, dropped the board's &aop als/las block now shared in t8142-peripherals.dtsi). Signed-off-by: Ryan Murray <ryan@aurorasilicon.org>
|
Merged integration/aurora (d1b022d); conflict in t8142-j815.dts resolved (kept the new J815 audio nodes, dropped the board als/las block now in t8142-peripherals.dtsi); t8142-j704/j813/j815 dtbs build, J813/J815 differ from integration only by aop_dart's implicit status=okay (plus phandle numbering). |
Problem
The MacBook Pro 14-inch M5 (J704) has no AOP, so no ambient light sensor (True Tone) and no lid angle. The AOP core, its two mailboxes and dart-aop were described in the J813/J815 sound file, and the
als/lasservices in each Air board file. The J704, J813 and J815 ADTs agree on all of them:/arm-io/aop: reg, interrupts 490-493.aop-exclave-mailbox: interrupts 497/494.dart-aop: interrupt 528./arm-io/aop/iop-aop-nubservice,alsincluded.mogul-laschip.Change
aop_mbox,aop_setup_mboxandaopwith itsalsandlasservices intot8142-peripherals.dtsi, on by default.aop_dartint8142.dtsi.t8142-j813-audio.dtsikeeps only&aop { aop_audio }and the rest of the sound description.als/lasblocks.The AOP runs without its audio child (the J815 does so today), and the driver creates a service device only when the firmware announces that service.
Testing
cpp + dtc before and after:
aop_dartlosing its now redundantstatus = "okay".alsandlas.dt-validate -mreports nothing new on any of the three boards.Still to run
dmesg | grep -i aop: the AOP boots and lists its services, with no DART fault or SError./sys/bus/iio/devices/*/in_illuminance_rawchanges between covered and under a lamp.Details
pmgr_aopstays in the sound file: it only holds audio domains.t8142-j815.dts: drop thealsblock there, keep accel/gyro.apple/aop-als-cal.bincomes from the installer.traces/kernel/20261119-dtfill-m5m6/(patches/t8142-aop with the per-board diffs).Assisted-by: LLM (Claude:Opus 5.5)