Repository navigation
ci: check all features with Clippy - #26591
Open
kumarUjjawal wants to merge 4 commits into
Open
kumarUjjawal wants to merge 4 commits into
kumarUjjawal wants to merge 4 commits into
Conversation
github-actions
Bot
added
development-process
kumarUjjawal
force-pushed
the
kumar/ci-all-features-clippy
branch
from
October 22, 2026 14:30
4733181 to
ff941ef
Compare
Contributor
Author
|
cc @neilconway |
alamb
approved these changes
Oct 23, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me -- thank you @kumarUjjawal
| # The all-features check builds snmalloc-sys, which requires CMake. | ||
| run: apt-get install -y --no-install-recommends cmake | ||
| - name: Run clippy with all features | ||
| run: cargo clippy --workspace --all-targets --all-features -- -D warnings |
Contributor
There was a problem hiding this comment.
It seems like maybe we should put this command in ci/scripts/rust_clippy.sh or whatever it calls so that it will be invoked by local agents / people too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #26181 and the CI follow-up requested in #26189 (comment).
This PR changes only
.github/workflows/rust.yml. The existing all-features lint failures are fixed separately in #26590; this branch does not include that fix. After #26590 merges, update this branch frommainso the new check can pass.Rationale for this change
CI currently runs Clippy with
avro,integration-tests,extended_tests, which missed the Arrow buffer-pool lint failures exposed by--all-features.Keep that existing check as well:
force_hash_collisionsdisables normal hashing code when all features are enabled, so the two configurations cover different code.What changes are included in this PR?
Add
cargo clippy --workspace --all-targets --all-features -- -D warningsafter the current Clippy step. Both steps use the existing Linux job, build setup, cache, and required check. Fork and merge-queue job conditions remain unchanged.What is the testing strategy for this PR?
clippy::mutable_key_typeerrors indatafusion/core/src/dataframe/mod.rs, addressed by fix: restore all-features Clippy for DataFrame aggregate rewrites #26590.Are there any user-facing changes?
CI Only Change