Skip to content

ci: check all features with Clippy #26591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kumarUjjawal wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −0
Open

ci: check all features with Clippy #26591

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff941ef
ci: check all features with Clippy
kumarUjjawal Oct 22, 2026
7d54612
Merge branch 'main' into kumar/ci-all-features-clippy
kumarUjjawal Oct 23, 2026
6efe3c7
Merge branch 'main' into kumar/ci-all-features-clippy
kumarUjjawal Oct 23, 2026
df8b818
ci: install CMake for all-features Clippy
kumarUjjawal Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,11 @@ jobs:
shared-key: "amd-ci-clippy"
- name: Run clippy
run: ci/scripts/rust_clippy.sh
- name: Install CMake
# The all-features check builds snmalloc-sys, which requires CMake.
run: apt-get install -y --no-install-recommends cmake
- name: Run clippy with all features
run: cargo clippy --workspace --all-targets --all-features -- -D warnings

@alamb alamb Oct 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like maybe we should put this command in ci/scripts/rust_clippy.sh or whatever it calls so that it will be invoked by local agents / people too


cargo-toml-formatting-checks:
name: check Cargo.toml formatting
Expand Down
Loading