Repository navigation
fix: restore all-features Clippy for DataFrame aggregate rewrites - #26590
Merged
kumarUjjawal merged 1 commit intoOct 23, 2026
Merged
Conversation
neilconway
approved these changes
Oct 22, 2026
neilconway
left a comment
Contributor
There was a problem hiding this comment.
I'm fine landing this as-is, but I wonder if it would be cleaner to add this to clippy.toml
ignore-interior-mutability = ["bytes::Bytes", "arrow_buffer::TrackedReservation"]
Contributor
|
And maybe should we add a CI check to prevent it again? |
Contributor
Author
I have opened a pr for that #26591 I will land that after this gets merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #26181.
Rationale for this change
On
mainat2717e25625ff0c51c1805f8df52d317979db74ec,cargo clippy --all-targets --all-features -- -D warningsfails with twoclippy::mutable_key_typeerrors inalias_aggregate_exprsandrewrite_select_aggs.The diagnostics follow
Exprthrough nestedScalarValuearrays to Arrow'sTrackedReservation. That mutable memory accounting does not affect expression equality or hashing. The earlierPushDownFilteroccurrences discussed in #26189 are already fixed onmain.What changes are included in this PR?
Add explained lint allowances on the aggregate rewrite map declaration and
rewrite_select_aggs, following existingExprkey handling. No runtime code changes.What is the testing strategy for this PR?
Reproduced both errors on unmodified
main; the exact command passes with this change.cargo fmt --allandgit diff --checkpass.uv run ./dev/rust_lint.shpasses, including CI Clippy, dependency checks, and documentation builds.All 240 existing DataFrame integration tests pass, including
test_dataframe_api_select_semantics, aggregate aliases, and name collisions.Extended workspace validation passes: 12,819 Rust tests passed, 8 ignored, and 538 SQL logic test files completed:
RUST_BACKTRACE=1 cargo test --profile ci \ --exclude datafusion-examples --exclude datafusion-benchmarks --exclude datafusion-cli \ --workspace --lib --tests --bins \ --features avro,json,backtrace,extended_tests,recursive_protection,parquet_encryptionNo new runtime tests or benchmarks: this change adds only lint attributes and explanatory comments.
Are there any user-facing changes?
The documented all-features Clippy command passes again. No SQL behavior or public API changes.