Skip to content

fix: restore all-features Clippy for DataFrame aggregate rewrites #26590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumarUjjawal merged 1 commit into from
Oct 23, 2026
+4 −0
Merged

fix: restore all-features Clippy for DataFrame aggregate rewrites #26590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions datafusion/core/src/dataframe/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,8 @@ fn alias_aggregate_exprs(
) -> Result<(Vec<Expr>, HashMap<Expr, Expr>)> {
let exprs = normalize_cols(exprs, plan)?;
let mut used = HashSet::new();
// Arrow buffer memory accounting does not affect expression equality or hashing.
#[allow(clippy::allow_attributes, clippy::mutable_key_type)]
let mut rewrite_map = HashMap::new();
let mut aliased = Vec::with_capacity(exprs.len());
for expr in exprs {
Expand All @@ -318,6 +320,8 @@ fn alias_aggregate_exprs(
}

/// Replace aggregate subexpressions with columns produced by the Aggregate node.
// Arrow buffer memory accounting does not affect expression equality or hashing.
#[allow(clippy::allow_attributes, clippy::mutable_key_type)]
fn rewrite_select_aggs(
expr_list: Vec<SelectExpr>,
input: &LogicalPlan,
Expand Down
Loading