Skip to content

Snowflake: Add DROP EXTERNAL VOLUME - #2750

Open
sabir-akhadov-localstack wants to merge 1 commit into
apache:mainfrom
localstack:pr/10-drop-external-volume
Open

sabir-akhadov-localstack wants to merge 1 commit into
apache:mainfrom
localstack:pr/10-drop-external-volume

Conversation

@sabir-akhadov-localstack

@sabir-akhadov-localstack sabir-akhadov-localstack commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Snowflake's DROP EXTERNAL VOLUME did not parse. Example that failed before:

DROP EXTERNAL VOLUME IF EXISTS my_vol;

This adds a new ObjectType::ExternalVolume so the statement goes through the generic Statement::Drop, the same way DROP WAREHOUSE does. IF EXISTS comes from the generic DROP path. The statement round-trips.

See the Snowflake DROP EXTERNAL VOLUME docs.

Split out of #2475 per review feedback. #2475 now covers only CREATE EXTERNAL VOLUME. The two PRs are independent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.35%. Comparing base (4c82c3a) to head (a941b00).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2750      +/-   ##
==========================================
+ Coverage   82.34%   82.35%   +0.01%     
==========================================
  Files          42       42              
  Lines       35263    35266       +3     
  Branches    35263    35266       +3     
==========================================
+ Hits        29039    29045       +6     
+ Misses       2677     2674       -3     
  Partials     3547     3547              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants