Repository navigation
Snowflake: Add CREATE EXTERNAL VOLUME - #2475
Open
sabir-akhadov-localstack wants to merge 1 commit into
Open
sabir-akhadov-localstack wants to merge 1 commit into
sabir-akhadov-localstack wants to merge 1 commit into
Conversation
This was referenced Sep 1, 2026
sabir-akhadov-localstack
force-pushed
the
pr/05-external-volume
branch
from
October 15, 2026 10:20
f770b81 to
896abcd
Compare
Contributor
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2475 +/- ##
==========================================
+ Coverage 82.34% 82.37% +0.02%
==========================================
Files 42 42
Lines 35263 35332 +69
Branches 35263 35332 +69
==========================================
+ Hits 29039 29106 +67
+ Misses 2677 2675 -2
- Partials 3547 3551 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sabir-akhadov-localstack
force-pushed
the
pr/05-external-volume
branch
2 times, most recently
from
October 27, 2026 16:27
2ec07ae to
0bc62fe
Compare
Contributor
|
Hi! Can you please split it into two PRs? |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sabir-akhadov-localstack
force-pushed
the
pr/05-external-volume
branch
from
October 28, 2026 08:14
0bc62fe to
aa80fef
Compare
Contributor
Author
|
Thanks, done. This PR now covers only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake's
CREATE EXTERNAL VOLUMEdid not parse. Example that failed before:This adds
CREATE [OR REPLACE] EXTERNAL VOLUME [IF NOT EXISTS], following the merged CREATE WAREHOUSE (#2388). Each storage location is a parenthesized key-value option list. It is parsed generically into the existingKeyValueOptions, so its fields, including the nestedENCRYPTION = (...)list, may appear in any order, as in real Snowflake. Only an empty location is rejected. Semantic checks, such as the requiredSTORAGE_BASE_URLor duplicate fields, are left to the consumer, in line with the parser's permissive stance. The trailingALLOW_WRITESandCOMMENTproperties are accepted in either order. The statement round-trips.See the Snowflake
CREATE EXTERNAL VOLUMEdocs.DROP EXTERNAL VOLUMEwas split out into #2750 per review feedback. The related ALTER (#2474), DESC (#2472) and SHOW (#2473) PRs are separate.