Skip to content

Snowflake: Add DESC[RIBE] EXTERNAL VOLUME - #2472

Open
sabir-akhadov-localstack wants to merge 2 commits into
apache:mainfrom
localstack:pr/08-desc-external-volume
Open

sabir-akhadov-localstack wants to merge 2 commits into
apache:mainfrom
localstack:pr/08-desc-external-volume

Conversation

@sabir-akhadov-localstack

@sabir-akhadov-localstack sabir-akhadov-localstack commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Snowflake's DESC[RIBE] EXTERNAL VOLUME <name> did not parse:

DESCRIBE EXTERNAL VOLUME my_vol;

Handles EXTERNAL VOLUME in parse_describe_object() and returns DescribeObject { object_type: ObjectType::ExternalVolume, .. }; the ObjectType::ExternalVolume variant is written identically to #2750.

See the Snowflake DESC EXTERNAL VOLUME docs.

Stacked on #2767; only the last commit is new.

Split out of #2397 per review feedback, alongside the CREATE/DROP (#2475), ALTER (#2474), and SHOW (#2473) PRs.

@sabir-akhadov-localstack

Copy link
Copy Markdown
Contributor Author

Rebased on latest main. @iffyio @LucaCappelletti94 could you take a look when you have a moment? (One of the PRs split out of #2397.)

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.85714% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.53%. Comparing base (c45d1f4) to head (0dec5bc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parser/mod.rs 91.30% 0 Missing and 2 partials ⚠️
src/ast/spans.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2472      +/-   ##
==========================================
+ Coverage   82.48%   82.53%   +0.04%     
==========================================
  Files          42       42              
  Lines       35469    35579     +110     
  Branches    35469    35579     +110     
==========================================
+ Hits        29258    29366     +108     
- Misses       2675     2676       +1     
- Partials     3536     3537       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sabir-akhadov-localstack
sabir-akhadov-localstack force-pushed the pr/08-desc-external-volume branch 2 times, most recently from 452ab17 to 3902ada Compare October 27, 2026 16:26
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs rebasing The PR has collisions with main and requires rebasing Snowflake

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants