Repository navigation
test: compare the V2 file insert's closed files as a set - #7335
Merged
mbutrovich merged 1 commit intoOct 30, 2026
Merged
Conversation
github-actions
Bot
added
enhancement
andygrove
added a commit
to andygrove/datafusion-comet
that referenced
this pull request
Oct 30, 2026
(cherry picked from commit 36b432c)
andygrove
added a commit
that referenced
this pull request
Oct 30, 2026
…7314) * fix: [branch-1.2] copy rows retained by identity broadcasts (#7260) (cherry picked from commit 84944e9) * test: compare the V2 file insert's closed files as a set (#7335) (cherry picked from commit 36b432c) * ci: move the macOS PR build to the macos-15 runner image GitHub retires the macos-14 runner image on November 2, 2026 and is already cancelling jobs on it during scheduled brownouts. (cherry picked from commit 2d168e8) --------- Co-authored-by: Ping Zhang <pingzh@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue. This is a test-only fix for a flaky assertion that failed CI on #7314.
Rationale for this change
The
CometParquetWriterSuitetest "an INSERT into a table of the V2 file source is written natively through Hadoop" writes two files from two concurrent tasks. It then asserts that the list of files closed equals the list of files created, in order. When the second task's file closes first, the test fails with the same two paths in swapped order, as it did in the Spark 4.0, JDK 21 [scans] job on #7314.What changes are included in this PR?
The assertion compares the closed and created files as sets, as the test "complex and temporal types are written through Hadoop" already does for its multi-partition write. The other tests in the suite that compare these lists in order write a single file, so their order cannot vary.
How are these changes tested?
The test itself is the change. It compiles and passes formatting locally, and CI runs the suite.