Skip to content

test: compare the V2 file insert's closed files as a set #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbutrovich merged 1 commit into from
Oct 30, 2026
+3 −1
Merged

test: compare the V2 file insert's closed files as a set #7335

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion spark/src/test/scala/org/apache/comet/parquet/CometParquetWriterSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2344,7 +2344,9 @@ class CometParquetWriterSuite extends CometParquetWriterTestBase {
captureWritePlan(sql("INSERT INTO v2_file_target SELECT * FROM v2_file_source"))
assertHasCometNativeWriteExec(plan)
assert(RecordingFileSystem.created.size == 2, RecordingFileSystem.created)
assert(RecordingFileSystem.closed.asScala == RecordingFileSystem.created.asScala)
// The two tasks run concurrently, so their files close in any order.
assert(
RecordingFileSystem.closed.asScala.toSet == RecordingFileSystem.created.asScala.toSet)
checkAnswer(spark.table("v2_file_target"), df)
}
}
Expand Down
Loading