Repository navigation
Conversation
(cherry picked from commit 36b432c)
github-actions
Bot
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Backport of #7335 to
branch-1.2. #7335 has no issue; it fixes a flaky test assertion that failed CI on #7314.Rationale for this change
The
CometParquetWriterSuitetest "an INSERT into a table of the V2 file source is written natively through Hadoop" compares the files closed with the files created, in order, even though two tasks write them concurrently.branch-1.2has the same assertion, and it already failed the Spark 4.0, JDK 21 [scans] job on the backport #7314. Backports tobranch-1.2keep hitting it until the branch gets the fix.branch-1.2is the newest release branch, so no newer branch needs a backport.branch-1.1doesn't have this test, so it needs no backport either.What changes are included in this PR?
git cherry-pick -x 36b432c896of the squash commit of #7335. It applied cleanly, and the change matches the source commit. The assertion compares the closed and created files as sets.How are these changes tested?
The test itself is the change.
./mvnw test-compilepasses on this branch with the default profile, and CI runs the suite.