Repository navigation
Conversation
) (cherry picked from commit 84944e9)
comphead
approved these changes
Oct 29, 2026
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Backport of #7260 to
branch-1.2. Part of #6741 onmain; #7260 does not close it.Rationale for this change
An identity broadcast retains every input row, but the JVM columnar-to-row converters reuse their row object. Materializing that iterator can repeat the last row of each batch instead of keeping the build rows, so the broadcast build side returns wrong results.
branch-1.2has the bug, so it needs the fix before 1.2.0 ships.branch-1.2is the newest release branch, so no newer branch needs a backport. #7260 carries nobackport-1.1label, so nobranch-1.1backport is part of this.What changes are included in this PR?
git cherry-pick -x 84944e98d8of the squash commit of #7260, with one adaptation. The pick conflicted in the import block ofCometExecRuleSuite.scala, becausebranch-1.2's import list is shorter thanmain's. I keptbranch-1.2's list and addedInternalRow;IdentityBroadcastModemerged cleanly.CometColumnarToRowExec.scalais identical to the source commit.How are these changes tested?
On this branch, with a
libcometbuilt frombranch-1.2plus #7085 (this change touches no native code):./mvnw test-compilepasses, including scalastyle.CometExecRuleSuitepasses: 99 succeeded, 0 failed, includingcolumnar-to-row identity broadcasts retain every build row.CometColumnarToRowExec.scalareverted tobranch-1.2, that test fails (98 succeeded, 1 failed), so the branch has the bug and the test catches it.