[criticalAY]

Note

Assisted-by: Opus 5.5

Purpose / Description

If the selected profile couldn't be opened at startup, AnkiDroid quietly opened Default instead, kept retrying the broken profile on every start, and the Switch profile screen stopped working. The Deck Picker now says which profile couldn't be opened, and offers to use Default from the next start so a profile that keeps failing can't trap the user.

Fixes

• Part of Add support for profiles #18117

Approach

check commit message

How Has This Been Tested?

added tests

Learning (optional, can help others)

NA

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[github-actions]

Important

Maintainers: This PR contains Strings changes

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

[david-allison]

Please add a screenshot test

[github-actions]

Snapshot diff report vs main. Open screenshot-diff for diffs.

• ProfileLoadFailureScreenshotTest: 2 changes

All 2 changed screenshots

ProfileLoadFailureScreenshotTest

• profile_load_failure_dialog_compare.png
• profile_load_failure_dialog_long_names_compare.png

[david-allison]

The screenshot doesn't give a hint that it's a profile load failure

[mikehardy]

Assisted-by: grok-4.7
strings_pass@d0a28b81e75833c3d69998cb4fd09c635364d24e

Thank you — naming the failed profile on the Deck Picker and offering “Use …” to set Default for the next start is a clear fix for the old silent fallback. I rebased locally onto current main without pushing; lint (lintAll, ktlintCheck, lint-rules:test), unit (jacocoUnitTestReport), and emulator (TEST_RELEASE_BUILD=true, emulator-5556 / API35_GAPI) passed. GitHub CI on this tip is green.

showProfileLoadFailure runs at the start of showStartupScreensAndDialogs before disk-space, fresh-install, and upgrade branches. consumeLoadFailure clears the static before the fragment-tag check; configuration change and process-restore tests keep a single dialog. selectDefaultProfile writes profiles_prefs on the application context while profileManager is null, matching the base context Default storage. The three new strings are profile_load_failed_title, profile_load_failed_message, and profile_load_failed_use_default; screenshot tests cover Work and long profile names.

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

some acceptable findings, no action required, just leaving for posterity: readLoadFailure swallows a registry read exception and returns null; an upgrade path can recreate() after the failure was already consumed.

Screenshot changes have been detected, so leaving this for a good manual look.

[david-allison]

🥳 🥳 🥳

LGTM, pick the ones you feel you want to handle. Nitpicks only

[mikehardy]

Assisted-by: Grok 4.7
strings_pass@a6d0cebb0f047c7be328b349ef4936f98ab05775

Thank you — naming the failed profile on the Deck Picker and offering “Use …” to commit Default for the next launch fixes the silent base-context fallback. I rebased locally onto current main without pushing; lint (lintAll, ktlintCheck, lint-rules:test), unit (jacocoUnitTestReport), and emulator (TEST_RELEASE_BUILD=true, emulator-5556 / API35_GAPI) passed. GitHub CI on this tip is green.

createOrNull clears attach/load failure state, then on exception records readLoadFailure; consumeLoadFailure is one-shot while loadFailure survives for restore matching. DeckPicker.showProfileLoadFailureIfAny avoids stacking dialogs and defers fatal startup until the dialog closes. The neutral button uses commit() on last_active_profile_id without auto-dismiss on failure. Tests cover copy, z-order, fatal-error gating, SD-card finish, registry id after Use vs OK, failed commit retry, configuration change, process restore, recovery with disk full / DB error, and Roborazzi for the dialog strings.

1. Sync Translations before merging this PR and wait for the action to complete
2. Review and merge the auto-generated PR in order to sync all user-submitted translations
3. Sync Translations again and merge the PR so the huge automated string changes caused by merging this PR are by themselves and easy to review

some acceptable findings, no action required, just leaving for posterity: readLoadFailure catches every exception and returns null with no log; an upgrade branch can recreate() after the failure was already consumed.

Screenshot changes have been detected, so leaving this for a good manual look.

[david-allison]

LGTM

[david-allison]

@criticalAY Could you ping on Discord (design channel) for a string review - I think we could tighten these up a little

Change LGTM.

Timebox max 3 days for feedback, then merge