Repository navigation
fix: error on profile load #22880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
criticalAY
wants to merge
1
commit into
ankidroid:main
Choose a base branch
from
criticalAY:profiles/load-failure-message
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+812
−2
Open
fix: error on profile load #22880
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
95 changes: 95 additions & 0 deletions
95
AnkiDroid/src/main/java/com/ichi2/anki/dialogs/ProfileLoadFailureDialog.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,95 @@ | ||
| // SPDX-License-Identifier: GPL-3.0-or-later | ||
| // SPDX-FileCopyrightText: 2026 Ashish Yadav <mailtoashish693@gmail.com> | ||
|
|
||
| package com.ichi2.anki.dialogs | ||
|
|
||
| import android.content.DialogInterface | ||
| import android.os.Bundle | ||
| import androidx.appcompat.app.AlertDialog | ||
| import androidx.fragment.app.FragmentActivity | ||
| import androidx.fragment.app.FragmentManager | ||
| import com.ichi2.anki.CommonString | ||
| import com.ichi2.anki.analytics.AnalyticsDialogFragment | ||
| import com.ichi2.anki.common.utils.android.showThemedToast | ||
| import com.ichi2.anki.multiprofile.ProfileManager | ||
| import com.ichi2.anki.multiprofile.ProfileName | ||
| import com.ichi2.anki.utils.ext.requireString | ||
| import com.ichi2.anki.utils.ext.setFragmentResultListener | ||
| import com.ichi2.utils.create | ||
| import com.ichi2.utils.message | ||
| import com.ichi2.utils.neutralButton | ||
| import com.ichi2.utils.positiveButton | ||
| import com.ichi2.utils.title | ||
| import timber.log.Timber | ||
|
|
||
| /** Tells the user their profile couldn't be opened, and offers to open Default from the next start. */ | ||
| class ProfileLoadFailureDialog : AnalyticsDialogFragment() { | ||
| private val profileName get() = ProfileName.fromTrustedSource(requireArguments().requireString(ARG_PROFILE_NAME)) | ||
| private val defaultProfileName get() = ProfileName.fromTrustedSource(requireArguments().requireString(ARG_DEFAULT_PROFILE_NAME)) | ||
|
|
||
| override fun onCreate(savedInstanceState: Bundle?) { | ||
| super.onCreate(savedInstanceState) | ||
| if (ProfileManager.LoadFailure(profileName, defaultProfileName) != ProfileManager.loadFailure) { | ||
| Timber.w("Dismissing a restored profile load failure that no longer applies") | ||
| dismiss() | ||
| } | ||
| } | ||
|
|
||
| override fun onCreateDialog(savedInstanceState: Bundle?): AlertDialog = | ||
| AlertDialog.Builder(requireContext()).create { | ||
| title(text = getString(CommonString.profile_load_failed_title, profileName.value)) | ||
| message(text = getString(CommonString.profile_load_failed_message, defaultProfileName.value, profileName.value)) | ||
| positiveButton(CommonString.dialog_ok) { | ||
| Timber.i("Profile load failure: OK pressed") | ||
| parentFragmentManager.setProfileLoadFailureClosedResult() | ||
| } | ||
| neutralButton(text = getString(CommonString.profile_load_failed_use_default, defaultProfileName.value)) | ||
| } | ||
|
|
||
| override fun onStart() { | ||
| super.onStart() | ||
| (requireDialog() as AlertDialog).neutralButton?.setOnClickListener { useDefaultProfile() } | ||
| } | ||
|
|
||
| override fun onCancel(dialog: DialogInterface) { | ||
| super.onCancel(dialog) | ||
| Timber.i("Profile load failure: cancelled") | ||
| parentFragmentManager.setProfileLoadFailureClosedResult() | ||
| } | ||
|
|
||
| private fun useDefaultProfile() { | ||
| Timber.i("Profile load failure: Use Default pressed") | ||
| if (!ProfileManager.selectDefaultProfile(requireContext().applicationContext)) { | ||
| Timber.w("Could not save Default as the profile to open next") | ||
| showThemedToast(requireContext(), getString(CommonString.something_wrong), shortLength = true) | ||
| return | ||
| } | ||
| val manager = parentFragmentManager | ||
| dismiss() | ||
| manager.setProfileLoadFailureClosedResult() | ||
| } | ||
|
|
||
| companion object { | ||
| const val TAG = "profileLoadFailure" | ||
| const val REQUEST_PROFILE_LOAD_FAILURE_CLOSED = "request_profile_load_failure_closed" | ||
| private const val ARG_PROFILE_NAME = "profileName" | ||
| private const val ARG_DEFAULT_PROFILE_NAME = "defaultProfileName" | ||
|
|
||
| fun newInstance(failure: ProfileManager.LoadFailure) = | ||
| ProfileLoadFailureDialog().apply { | ||
| arguments = | ||
| Bundle().apply { | ||
| putString(ARG_PROFILE_NAME, failure.profileName.value) | ||
| putString(ARG_DEFAULT_PROFILE_NAME, failure.defaultProfileName.value) | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| fun FragmentActivity.registerProfileLoadFailureClosedHandler(action: () -> Unit) { | ||
| setFragmentResultListener(ProfileLoadFailureDialog.REQUEST_PROFILE_LOAD_FAILURE_CLOSED) { _, _ -> action() } | ||
| } | ||
|
|
||
| private fun FragmentManager.setProfileLoadFailureClosedResult() { | ||
| setFragmentResult(ProfileLoadFailureDialog.REQUEST_PROFILE_LOAD_FAILURE_CLOSED, Bundle()) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.