chore: v2 - instrument pipeline folders (table, dialogs, connect folder)#2223
Merged
maxy-shpfy merged 1 commit intoMay 8, 2026
Conversation
This was referenced May 6, 2026
🎩 PreviewA preview build has been created at: |
This was referenced May 6, 2026
Collaborator
Author
8 tasks
cbb968d to
48f3fd7
Compare
40e8f2b to
924f710
Compare
48f3fd7 to
52e6c1e
Compare
morgan-wowk
approved these changes
May 6, 2026
camielvs
reviewed
May 7, 2026
camielvs
reviewed
May 7, 2026
camielvs
approved these changes
May 7, 2026
52e6c1e to
e4528a2
Compare
924f710 to
cdc1809
Compare
Collaborator
Author
Merge activity
|
e4528a2 to
dc095d5
Compare
59d68d9 to
2555bc8
Compare
dc095d5 to
261ca35
Compare
2555bc8 to
e6e487f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Contributes to https://github.com/Shopify/oasis-frontend/issues/607
Adds analytics tracking across the v2 Pipeline Folders feature and the shared
PipelineRow/PaginationControlscomponents. Tracked interactions include:open_mode: embedded, editor_new_tab, editor_same_tab), pipeline selection toggled, and delete confirmation opened. A newanalyticsTrackingPrefixprop allows callers to namespace events — the home list usespipeline_home.tableand the v2 folder table usesv2.pipeline_folders.table.analyticsTrackingPrefixprop onPaginationControls.navigation_context), folder selection toggled.navigation_context.PaginationControlsgains an optionalanalyticsTrackingPrefixprop; when provided, tracking attributes are spread onto each navigation button.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
pipeline_home.tableprefix.Additional Comments
The
indeterminatecheckbox state is now explicitly guarded against inhandleCheckboxChange(PipelineRow) andhandleSelectAll(FolderPipelineTable) to avoid passing a non-boolean value to downstream handlers.