Skip to content

chore: v2 - instrument pipeline folders (table, dialogs, connect folder)#2223

Merged
maxy-shpfy merged 1 commit into
masterfrom
05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_
May 8, 2026
Merged

chore: v2 - instrument pipeline folders (table, dialogs, connect folder)#2223
maxy-shpfy merged 1 commit into
masterfrom
05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 6, 2026

Description

Contributes to https://github.com/Shopify/oasis-frontend/issues/607

Adds analytics tracking across the v2 Pipeline Folders feature and the shared PipelineRow / PaginationControls components. Tracked interactions include:

  • PipelineRow: pipeline opened (with open_mode: embedded, editor_new_tab, editor_same_tab), pipeline selection toggled, and delete confirmation opened. A new analyticsTrackingPrefix prop allows callers to namespace events — the home list uses pipeline_home.table and the v2 folder table uses v2.pipeline_folders.table.
  • FolderPipelineTable: select-all toggled, search cleared, and pagination navigation (first/previous/next) via the new analyticsTrackingPrefix prop on PaginationControls.
  • FolderRow: folder opened (with navigation_context), folder selection toggled.
  • FolderRowMenu: row menu opened, favorite toggled, rename dialog opened, delete confirmation opened.
  • ParentFolderRow: parent folder navigation tracked with navigation_context.
  • ConnectFolderButton: connect folder clicked (primary and split-button variants), driver menu opened, driver option selected.
  • CreateFolderDialog: dialog impression, cancel, submit, and successful folder creation tracked.
  • RenameFolderDialog: dialog impression, cancel, and submit tracked.
  • SelectionToolbar: move, bulk delete open, and clear selection tracked.
  • FolderPermissionBanner / FolderList: grant access, post-grant refresh, permission-gated folder refresh, and disconnect tracked.

PaginationControls gains an optional analyticsTrackingPrefix prop; when provided, tracking attributes are spread onto each navigation button.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

  1. Navigate to the v2 Pipeline Folders page.
  2. Perform actions such as opening a folder, opening a pipeline, connecting a folder, creating/renaming/deleting a folder, toggling selection, and paginating.
  3. Verify that the corresponding analytics events fire with the correct prefixes and metadata in your analytics tooling.
  4. Confirm the home pipeline list still fires events under the pipeline_home.table prefix.

Additional Comments

The indeterminate checkbox state is now explicitly guarded against in handleCheckboxChange (PipelineRow) and handleSelectAll (FolderPipelineTable) to avoid passing a non-boolean value to downstream handlers.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🎩 Preview

A preview build has been created at: 05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_/e6e487f

@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from cbb968d to 48f3fd7 Compare May 6, 2026 17:56
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_ branch 2 times, most recently from 40e8f2b to 924f710 Compare May 6, 2026 18:08
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from 48f3fd7 to 52e6c1e Compare May 6, 2026 18:08
@maxy-shpfy maxy-shpfy marked this pull request as ready for review May 6, 2026 18:14
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner May 6, 2026 18:14
Comment thread src/components/Home/PipelineSection/PipelineRow.tsx Outdated
Comment thread src/components/shared/PaginationControls.tsx Outdated
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from 52e6c1e to e4528a2 Compare May 8, 2026 05:29
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_ branch from 924f710 to cdc1809 Compare May 8, 2026 05:29
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 8, 2026

Merge activity

@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from e4528a2 to dc095d5 Compare May 8, 2026 14:52
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_ branch 2 times, most recently from 59d68d9 to 2555bc8 Compare May 8, 2026 15:52
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from dc095d5 to 261ca35 Compare May 8, 2026 15:52
@maxy-shpfy maxy-shpfy changed the base branch from 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions to graphite-base/2223 May 8, 2026 16:02
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/2223 to master May 8, 2026 16:05
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_ branch from 2555bc8 to e6e487f Compare May 8, 2026 16:06
@maxy-shpfy maxy-shpfy merged commit 87e9d35 into master May 8, 2026
17 checks passed
@maxy-shpfy maxy-shpfy deleted the 05-06-chore_v2_-_instrument_pipeline_folders_table_dialogs_connect_folder_ branch May 8, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants