Skip to content

chore: v2 - instrument pipeline tree and validation resolutions analytics#2220

Merged
maxy-shpfy merged 1 commit into
masterfrom
05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics
May 8, 2026
Merged

chore: v2 - instrument pipeline tree and validation resolutions analytics#2220
maxy-shpfy merged 1 commit into
masterfrom
05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 6, 2026

Description

Contributes to https://github.com/Shopify/oasis-frontend/issues/607

Adds tracking attributes to interactive elements within the Pipeline Tree section of the pipeline editor. The following user interactions are now instrumented:

  • Clicking a validation issue row (v2.pipeline_editor.pipeline_tree.validation_issue_select)
  • Navigating to the root node (v2.pipeline_editor.pipeline_tree.root_nav)
  • Toggling the root node expand/collapse (v2.pipeline_editor.pipeline_tree.root_expand_toggle)
  • Navigating to a subgraph node (v2.pipeline_editor.pipeline_tree.subgraph_nav)
  • Toggling a subgraph node expand/collapse (v2.pipeline_editor.pipeline_tree.subgraph_expand_toggle)
  • Navigating to a task leaf node (v2.pipeline_editor.pipeline_tree.task_nav)
  • Unsetting a bad reference argument (v2.pipeline_editor.pipeline_tree.resolution.bad_reference_unset)
  • Deleting an entity from a validation resolution (v2.pipeline_editor.pipeline_tree.resolution.delete_entity)
  • Renaming a duplicate entity (v2.pipeline_editor.pipeline_tree.resolution.duplicate_rename)
  • Deleting a duplicate entity (v2.pipeline_editor.pipeline_tree.resolution.duplicate_delete)
  • Saving a renamed entity (v2.pipeline_editor.pipeline_tree.resolution.rename_save)

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Interact with the pipeline tree in the editor — navigate nodes, expand/collapse subgraphs, and trigger validation resolutions — then verify that the corresponding tracking events are fired for each action listed above.

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🎩 Preview

A preview build has been created at: 05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics/0719936

@maxy-shpfy maxy-shpfy force-pushed the 05-05-chore_v2_-_instrument_task_arguments_and_code_editor_analytics branch from 9dd2d60 to a19dd97 Compare May 6, 2026 17:56
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics branch from 94d54c3 to 257d925 Compare May 6, 2026 17:56
@maxy-shpfy maxy-shpfy force-pushed the 05-05-chore_v2_-_instrument_task_arguments_and_code_editor_analytics branch from a19dd97 to a5ca50d Compare May 6, 2026 18:08
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics branch from 257d925 to 80c7bf1 Compare May 6, 2026 18:08
@maxy-shpfy maxy-shpfy marked this pull request as ready for review May 6, 2026 18:13
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner May 6, 2026 18:13
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics branch from 80c7bf1 to 6a1b5ec Compare May 8, 2026 05:29
@maxy-shpfy maxy-shpfy force-pushed the 05-05-chore_v2_-_instrument_task_arguments_and_code_editor_analytics branch from a5ca50d to 539eaac Compare May 8, 2026 05:29
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 8, 2026

Merge activity

  • May 8, 5:34 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 8, 6:01 AM UTC: Graphite couldn't merge this PR because it had merge conflicts.
  • May 8, 3:57 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 8, 3:57 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy changed the base branch from 05-05-chore_v2_-_instrument_task_arguments_and_code_editor_analytics to graphite-base/2220 May 8, 2026 05:56
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/2220 to master May 8, 2026 05:59
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics branch from 6a1b5ec to 6037a8c Compare May 8, 2026 14:52
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics branch from 6037a8c to 0719936 Compare May 8, 2026 15:52
@maxy-shpfy maxy-shpfy merged commit e018b85 into master May 8, 2026
17 checks passed
@maxy-shpfy maxy-shpfy deleted the 05-06-chore_v2_-_instrument_pipeline_tree_and_validation_resolutions_analytics branch May 8, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants