Skip to content

chore: v2 - instrument run view shell, menu bar, toolbars, and run-scoped actions#2222

Merged
maxy-shpfy merged 1 commit into
masterfrom
05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions
May 8, 2026
Merged

chore: v2 - instrument run view shell, menu bar, toolbars, and run-scoped actions#2222
maxy-shpfy merged 1 commit into
masterfrom
05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 6, 2026

Description

Contributes to https://github.com/Shopify/oasis-frontend/issues/607

Adds analytics tracking to the Run View page across a wide range of user interactions, including:

  • Toolbar buttons (View YAML, Inspect Pipeline, Clone, Cancel, Rerun)
  • Menu bar items (Home link, Run menu, View menu, auto-layout selection)
  • Canvas controls (zoom in/out, fit view, interactive toggle, minimap clicks)
  • Context panel actions (task detail tab switching, open logs in new tab, input/output link sharing, pipeline title copy)
  • Subgraph breadcrumb navigation (run view only)
  • Task node "Open Logs" button

To support passing tracking attributes through to underlying elements, several button and link components (CancelPipelineRunButton, ClonePipelineButton, InspectPipelineButton, RerunPipelineButton, LinkNodeButton, OpenLogsInNewWindowLink) have been updated to accept and forward additional props via ComponentPropsWithoutRef intersection types, excluding controlled props like onClick, tooltip, variant, and children.

SubgraphBreadcrumbsView now accepts an optional getCrumbTracking callback to attach per-crumb tracking attributes, and SubgraphBreadcrumbs uses the current route to conditionally provide this callback only in the run view context.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Test Instructions

Navigate to the Run View and exercise the following interactions to verify tracking events are fired:

  1. Click the Home link in the menu bar
  2. Open the Run and View menus and select items
  3. Use the canvas controls (zoom in/out, fit view, interactive toggle) and click the minimap
  4. Open a task node's context panel and switch between tabs
  5. Use the toolbar buttons (View YAML, Clone, Cancel, Rerun, Inspect)
  6. Click the "Open in new tab" logs link
  7. Click the shareable link button on input/output nodes
  8. Navigate subgraph breadcrumbs

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 6, 2026

🎩 Preview

A preview build has been created at: 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions/36f4907

@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_history_debug_panel_and_editor_shell_analytics branch from a339735 to 900a69c Compare May 6, 2026 17:56
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch 2 times, most recently from 48f3fd7 to 52e6c1e Compare May 6, 2026 18:08
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_history_debug_panel_and_editor_shell_analytics branch from 900a69c to 0929566 Compare May 6, 2026 18:08
@maxy-shpfy maxy-shpfy marked this pull request as ready for review May 6, 2026 18:14
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner May 6, 2026 18:14
Comment thread src/components/PipelineRun/components/InspectPipelineButton.tsx
Comment thread src/components/shared/SubgraphBreadcrumbsView.tsx Outdated
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from 52e6c1e to e4528a2 Compare May 8, 2026 05:29
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_history_debug_panel_and_editor_shell_analytics branch from 0929566 to cd873c3 Compare May 8, 2026 05:29
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 8, 2026

Merge activity

@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from e4528a2 to dc095d5 Compare May 8, 2026 14:52
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_history_debug_panel_and_editor_shell_analytics branch 2 times, most recently from 7565f34 to bcbaa14 Compare May 8, 2026 15:52
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from dc095d5 to 261ca35 Compare May 8, 2026 15:52
@maxy-shpfy maxy-shpfy changed the base branch from 05-06-chore_v2_-_instrument_history_debug_panel_and_editor_shell_analytics to graphite-base/2222 May 8, 2026 15:58
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/2222 to master May 8, 2026 16:01
@maxy-shpfy maxy-shpfy force-pushed the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch from 261ca35 to 36f4907 Compare May 8, 2026 16:02
@maxy-shpfy maxy-shpfy merged commit 3652cad into master May 8, 2026
17 checks passed
@maxy-shpfy maxy-shpfy deleted the 05-06-chore_v2_-_instrument_run_view_shell_menu_bar_toolbars_and_run-scoped_actions branch May 8, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants