chore: v2 - instrument run view shell, menu bar, toolbars, and run-scoped actions#2222
Merged
maxy-shpfy merged 1 commit intoMay 8, 2026
Conversation
This was referenced May 6, 2026
Collaborator
Author
🎩 PreviewA preview build has been created at: |
a339735 to
900a69c
Compare
48f3fd7 to
52e6c1e
Compare
900a69c to
0929566
Compare
morgan-wowk
approved these changes
May 6, 2026
camielvs
reviewed
May 7, 2026
camielvs
reviewed
May 7, 2026
camielvs
approved these changes
May 7, 2026
52e6c1e to
e4528a2
Compare
0929566 to
cd873c3
Compare
Collaborator
Author
Merge activity
|
e4528a2 to
dc095d5
Compare
7565f34 to
bcbaa14
Compare
dc095d5 to
261ca35
Compare
261ca35 to
36f4907
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Contributes to https://github.com/Shopify/oasis-frontend/issues/607
Adds analytics tracking to the Run View page across a wide range of user interactions, including:
To support passing tracking attributes through to underlying elements, several button and link components (
CancelPipelineRunButton,ClonePipelineButton,InspectPipelineButton,RerunPipelineButton,LinkNodeButton,OpenLogsInNewWindowLink) have been updated to accept and forward additional props viaComponentPropsWithoutRefintersection types, excluding controlled props likeonClick,tooltip,variant, andchildren.SubgraphBreadcrumbsViewnow accepts an optionalgetCrumbTrackingcallback to attach per-crumb tracking attributes, andSubgraphBreadcrumbsuses the current route to conditionally provide this callback only in the run view context.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Navigate to the Run View and exercise the following interactions to verify tracking events are fired:
Additional Comments