feat: v2 - runs and submissions - add latest run#2199
Open
maxy-shpfy wants to merge 1 commit intomasterfrom
Open
feat: v2 - runs and submissions - add latest run#2199maxy-shpfy wants to merge 1 commit intomasterfrom
maxy-shpfy wants to merge 1 commit intomasterfrom
Conversation
This was referenced May 4, 2026
Collaborator
Author
8 tasks
🎩 PreviewA preview build has been created at: |
8 tasks
363ba9f to
8d997d9
Compare
43e295f to
effa810
Compare
8d997d9 to
8a7e548
Compare
effa810 to
490871b
Compare
8a7e548 to
205308a
Compare
490871b to
a2f61c0
Compare
205308a to
4c0fa3e
Compare
a2f61c0 to
564779d
Compare
8 tasks
564779d to
abdd78c
Compare
Collaborator
|
I'm also not a huge fan of the show all runs being a pop-up. What's stopping us from putting all the runs in most recent runs in a list that is scrollable or expandable? |
Mbeaulne
reviewed
May 5, 2026
Comment on lines
+113
to
+132
| <Separator /> | ||
| <BlockStack className="p-2"> | ||
| <InlineStack align="space-between" className="w-full"> | ||
| <Heading level={3}>The most recent run:</Heading> | ||
| {showMoreButton} | ||
| </InlineStack> | ||
| <div className="flex-1 min-h-0 overflow-y-auto w-full"> | ||
| <PipelineRunsList | ||
| pipelineName={pipelineName} | ||
| showTitle={false} | ||
| defaultShowingRuns={1} | ||
| showMoreButton={false} | ||
| overviewConfig={{ | ||
| showName: false, | ||
| showDescription: true, | ||
| showTaskStatusBar: false, | ||
| }} | ||
| /> | ||
| </div> | ||
| </BlockStack> |
Collaborator
There was a problem hiding this comment.
food for thought. DONT CHANGE HERE!
Maybe we add a prop to the block stack component that allows you to define a separator above or below or both. That way we don't have to manually add separators in throughout the code.
abdd78c to
5891b89
Compare
8d911fa to
c4834fd
Compare
5891b89 to
62299cd
Compare
c4834fd to
5939dc6
Compare
62299cd to
aba37e8
Compare
5939dc6 to
41c4069
Compare
aba37e8 to
a64720d
Compare
a64720d to
d351aba
Compare
Collaborator
Author
|
@Mbeaulne I removed "Show all runs" |
camielvs
reviewed
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Contributes to https://github.com/Shopify/oasis-frontend/issues/613
Adds a "most recent run" section to the
RunsAndSubmissionContentpanel in the Editor. This displays the latest pipeline run directly within the runs and submission sidebar, along with a "Show all runs" button that opens the full recent executions list when a pipeline name is available.UX: the most recent run appears immediately , so it is easier to reach compared to toast message.
Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Test Instructions
Additional Comments
The
PipelineRunsListis configured to show only 1 run by default, with the name and task status bar hidden, but the description visible.