Skip to content

feat: v2 - add runs and submissions window#2197

Merged
maxy-shpfy merged 1 commit intomasterfrom
05-03-feat_v2_-_add_runs_and_submissions_window
May 7, 2026
Merged

feat: v2 - add runs and submissions window#2197
maxy-shpfy merged 1 commit intomasterfrom
05-03-feat_v2_-_add_runs_and_submissions_window

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 4, 2026

Description

Closes https://github.com/Shopify/oasis-frontend/issues/613

Adds a new "Runs & Submissions" window to the pipeline editor. This window surfaces the Tangle submitter and (optionally) the Google Cloud submitter in a dedicated, persistent docked panel on the left side of the editor. When no pipeline is loaded, the window displays an empty state. If the user is not authorized, a HuggingFace sign-in button is shown in place of the submission controls.

The window is registered in the default and "All" view presets, making it visible by default alongside the component library, recent runs, and pipeline details panels.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • New feature
  • Improvement
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

image.png

Test Instructions

  1. Open the pipeline editor.
  2. Verify the "Runs & Submissions" window appears docked on the left side.
  3. With a pipeline loaded and a valid authorization, confirm the Tangle submitter is displayed.
  4. Without authorization, confirm the HuggingFace sign-in button is shown instead.
  5. With VITE_ENABLE_GOOGLE_CLOUD_SUBMITTER=true, confirm the Google Cloud submitter also appears.
  6. With no pipeline loaded, confirm the empty state ("No pipeline loaded") is displayed.
  7. Verify the window appears in both the Default and All view presets.

Additional Comments

The Google Cloud submitter visibility is controlled by the VITE_ENABLE_GOOGLE_CLOUD_SUBMITTER environment variable and remains opt-in.

Known issues

Issues to be addressed downstream PRs:

  • Default height is too big
  • Window is ordered not at the beginning
  • "Warning" level validation is not preventing from submitting

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

🎩 Preview

A preview build has been created at: 05-03-feat_v2_-_add_runs_and_submissions_window/bbaebd0

Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 4, 2026

@maxy-shpfy maxy-shpfy changed the base branch from 05-03-fix_v2_-_sync_visual_selected_state_of_the_node to graphite-base/2197 May 4, 2026 05:36
@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_add_runs_and_submissions_window branch from 3c7b3e1 to f300e35 Compare May 4, 2026 05:36
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/2197 to master May 4, 2026 05:37
@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_add_runs_and_submissions_window branch from f300e35 to 7fbeb40 Compare May 4, 2026 20:10
@maxy-shpfy maxy-shpfy marked this pull request as ready for review May 4, 2026 20:26
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner May 4, 2026 20:26
Comment thread src/routes/v2/pages/Editor/components/RunsAndSubmissionContent.tsx Outdated
Comment thread src/routes/v2/pages/Editor/components/RunsAndSubmissionContent.tsx Outdated
Comment thread src/routes/v2/pages/Editor/components/RunsAndSubmissionContent.tsx Outdated
Copy link
Copy Markdown
Collaborator

Mbeaulne commented May 5, 2026

I've also noticed that you can submit a pipeline if there is validation errors (specifically input nodes at root not having values). so I believe the current behaviour is that you can submit if an input is missing a value, but the arguments panel will pop up.

Copy link
Copy Markdown
Collaborator Author

@Mbeaulne that's known issue - it will be addressed separately, not in scope of this PR.

@maxy-shpfy maxy-shpfy requested a review from Mbeaulne May 5, 2026 18:26
@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_add_runs_and_submissions_window branch 2 times, most recently from 0ba40ca to 50ed8a5 Compare May 5, 2026 18:53
Copy link
Copy Markdown
Collaborator Author

Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 7, 2026

Merge activity

  • May 7, 3:37 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 7, 3:38 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 7, 3:41 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy force-pushed the 05-03-feat_v2_-_add_runs_and_submissions_window branch from 50ed8a5 to bbaebd0 Compare May 7, 2026 15:37
@maxy-shpfy maxy-shpfy merged commit 027e3a9 into master May 7, 2026
16 of 17 checks passed
@maxy-shpfy maxy-shpfy deleted the 05-03-feat_v2_-_add_runs_and_submissions_window branch May 7, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants