Skip to content

fix: v2 - rectangle selection of one node#2195

Merged
maxy-shpfy merged 1 commit intomasterfrom
05-03-fix_v2_-_rectangle_selection_of_one_node
May 7, 2026
Merged

fix: v2 - rectangle selection of one node#2195
maxy-shpfy merged 1 commit intomasterfrom
05-03-fix_v2_-_rectangle_selection_of_one_node

Conversation

@maxy-shpfy
Copy link
Copy Markdown
Collaborator

@maxy-shpfy maxy-shpfy commented May 3, 2026

Description

When a single node is selected in the editor, selectNode is now explicitly called with the node's id and type. Previously, single-node selections only cleared the multi-selection state without triggering selectNode, which could leave the editor in an inconsistent selection state.

Related Issue and Pull requests

Type of Change

  • Bug fix
  • Improvement
  • New feature
  • Cleanup/Refactor
  • Breaking change
  • Documentation update

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Screenshots (if applicable)

Before:
Screen Recording 2026-05-03 at 4.30.30 PM.mov (uploaded via Graphite)

After:
Screen Recording 2026-05-03 at 4.31.19 PM.mov (uploaded via Graphite)

Test Instructions

  1. Open the editor and using Shift+Drag select ONE node (maybe plus edge).
  2. Verify that the node becomes properly selected and its properties/details are reflected in the editor panel.
  3. Select multiple nodes and confirm multi-selection behavior still works as expected.
  4. Deselect all nodes and confirm the editor clears the selection state correctly.

Additional Comments

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

🎩 Preview

A preview build has been created at: 05-03-fix_v2_-_rectangle_selection_of_one_node/07a3110

Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 3, 2026

@maxy-shpfy maxy-shpfy force-pushed the 05-01-fix_v2_-_proper_undo_for_del_action_on_canvas branch from 5a1f6ef to 4b8814b Compare May 5, 2026 05:48
@maxy-shpfy maxy-shpfy force-pushed the 05-03-fix_v2_-_rectangle_selection_of_one_node branch 2 times, most recently from 925dda5 to 6276429 Compare May 7, 2026 14:54
@maxy-shpfy maxy-shpfy force-pushed the 05-01-fix_v2_-_proper_undo_for_del_action_on_canvas branch 2 times, most recently from 11e9a88 to 90ed331 Compare May 7, 2026 17:06
@maxy-shpfy maxy-shpfy force-pushed the 05-03-fix_v2_-_rectangle_selection_of_one_node branch from 6276429 to 49f1d04 Compare May 7, 2026 17:06
Copy link
Copy Markdown
Collaborator Author

maxy-shpfy commented May 7, 2026

Merge activity

  • May 7, 7:46 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 7, 7:51 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 7, 7:53 PM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy changed the base branch from 05-01-fix_v2_-_proper_undo_for_del_action_on_canvas to graphite-base/2195 May 7, 2026 19:46
@maxy-shpfy maxy-shpfy changed the base branch from graphite-base/2195 to master May 7, 2026 19:49
@maxy-shpfy maxy-shpfy force-pushed the 05-03-fix_v2_-_rectangle_selection_of_one_node branch from 49f1d04 to 07a3110 Compare May 7, 2026 19:50
@maxy-shpfy maxy-shpfy merged commit 3b58942 into master May 7, 2026
17 checks passed
@maxy-shpfy maxy-shpfy deleted the 05-03-fix_v2_-_rectangle_selection_of_one_node branch May 7, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants