Repository navigation
fix(mcp): refuse every server start while MCP is off - #3368
Merged
Merged
Conversation
This was referenced Oct 12, 2026
Signed-off-by: Dat Ngo Quoc <datlechin@gmail.com>
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Turning Enable MCP Server off did not keep the listener down.
tablepro://integrations/start-mcp, pairing and the bridge's lazy start all bound it anyway, because the toggle was checked only at launch.Change
MCPServerManager.performStart, which every start path reaches, refuses while MCP is off and throws a typed error naming Settings > MCP.start-mcpwrites a refusal file;tablepro-mcpreads it and fails within a poll interval instead of timing out after 10 seconds. A TablePro launched only for that refused start quits again.Security: narrows access only. With MCP off no path binds a listener; nothing new is reachable.
Verified
MCPServerOffContractTestsdrives launch,start-mcp, the Settings restart and pairing with MCP off and asserts no listener, no handshake and the typed error.MCPBridgeRefusalTestscovers the bridge's fast failure and a stale refusal.Docs: TableProApp/docs#7