Repository navigation
chore: delete dead code and the unread managed policy keys - #3378
Merged
Merged
Conversation
Signed-off-by: Dat Ngo Quoc <datlechin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #3376.
Why
Code with no reader in the app, verified against
TablePro/,Packages/,Plugins/,TableProMobile/and the tests.Change
OllamaDetector(no caller) andMCPStdioMessageTransportwith its tests (not compiled into themcp-serverhelper, no caller).RecordingBridgeLogger, which lived in those tests, moves toTableProTests/Core/MCP/Helpers/for the bridge suites that still use it.SyncCoordinator.handleRemoteNotification()and the notification pull behind it: the Mac app never registers for remote notifications, so the deferral flags, the pull task and its test were unreachable.TableLoadHistoryStore.records()andexportJSON()and the export tests. The retention and corruption tests now append through the store and read the file back.mcpServerDisabled,aiAssistantDisabledandpluginInstallDisabledmanaged policy keys, plusbool(_:)andisManaged(_:), which only those keys or tests read.minimumSafeModeLevelstays.Verified
The touched suites and the bridge suites pass. No user-visible change: none of the removed keys was ever read.
Not in this PR