Skip to content

chore: delete dead code and the unread managed policy keys - #3378

Merged
datlechin merged 3 commits into
mainfrom
chore/delete-dead-code
Oct 12, 2026
Merged

datlechin merged 3 commits into
mainfrom
chore/delete-dead-code

Conversation

@datlechin

Copy link
Copy Markdown
Member

Stacked on #3376.

Why

Code with no reader in the app, verified against TablePro/, Packages/, Plugins/, TableProMobile/ and the tests.

Change

  • Delete OllamaDetector (no caller) and MCPStdioMessageTransport with its tests (not compiled into the mcp-server helper, no caller). RecordingBridgeLogger, which lived in those tests, moves to TableProTests/Core/MCP/Helpers/ for the bridge suites that still use it.
  • Delete SyncCoordinator.handleRemoteNotification() and the notification pull behind it: the Mac app never registers for remote notifications, so the deferral flags, the pull task and its test were unreachable.
  • Delete TableLoadHistoryStore.records() and exportJSON() and the export tests. The retention and corruption tests now append through the store and read the file back.
  • Delete the mcpServerDisabled, aiAssistantDisabled and pluginInstallDisabled managed policy keys, plus bool(_:) and isManaged(_:), which only those keys or tests read. minimumSafeModeLevel stays.

Verified

The touched suites and the bridge suites pass. No user-visible change: none of the removed keys was ever read.

Not in this PR

Base automatically changed from perf/icloud-sync-arm-when-on to main October 12, 2026 13:04
Signed-off-by: Dat Ngo Quoc <datlechin@gmail.com>
@datlechin
datlechin merged commit c89aa32 into main Oct 12, 2026
8 of 10 checks passed
@datlechin
datlechin deleted the chore/delete-dead-code branch October 12, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant