Skip to content

feat(hig): show Edit > Data only in data file windows - #3364

Merged
datlechin merged 2 commits into
mainfrom
feat/edit-data-data-file-windows
Oct 12, 2026
Merged

datlechin merged 2 commits into
mainfrom
feat/edit-data-data-file-windows

Conversation

@datlechin

@datlechin datlechin commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

Why

Edit > Data holds 20 commands plus Change Case that only a data file window answers. Every connection window showed the whole submenu dimmed.

Change

  • Edit > Data and the separator above it are hidden unless a data file window would receive its commands (resolved through the responder chain, so a sheet or popover on that window keeps it).
  • The Edit menu's delegate updates the group in menuNeedsUpdate, which AppKit calls before the menu opens and before it matches a key equivalent.
  • Every item in the group is hidden, not only the submenu: measured on macOS 27, a hidden submenu still fires its items' key equivalents (Cmd+Shift+H).

Verified

EditDataMenuGroupTests covers the built state, the receiver check, and Cmd+Shift+H not matching while hidden, including through the delegate. SingleWindowMenuContractUITests.testConnectionWindowLeavesOutEditData checks a connection window and DataFileWindowUITests still opens Edit > Data in a data file window; both run on CI (the local UI runner could not enable automation mode).

Not in this PR

Docs: TableProApp/docs#6

Signed-off-by: Dat Ngo Quoc <datlechin@gmail.com>
@datlechin
datlechin merged commit eac20e4 into main Oct 12, 2026
4 checks passed
@datlechin
datlechin deleted the feat/edit-data-data-file-windows branch October 12, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant