Repository navigation
Conversation
Member
Author
|
Superseded by #3390, which makes the same snapshot fix and also repairs the hub ratchet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
maindoes not compileTableProTests: #3367's snapshot test callsMainMenuBuilder.buildas if it returned anNSMenu, and #3360 changed it to returnBuiltMainMenu. The golden is also stale: #3373, #3379 and #3364 merged after it without re-recording.Change
BuiltMainMenu.barand its own Services menu. The build no longer touchesNSApp, so the save and restore around it is gone.ChromeSnapshot.jsonon currentmain: File > Server-Side Export… and the Dashboard toolbar item removed, Edit > Data recorded as hidden outside data file windows.Verified
ChromeSnapshotTestspasses in compare mode after the re-record, withMainMenuBuildPurityTestsandMainMenuStructureTests.